fix: prioritize EVM chains when resolving chainId collisions

ChainId can have collisions across chain families (e.g., both Ethereum
and Aptos have chainId=1). Updated resolveToInternalId to collect all
matches and prioritize EVM chains, since by-chain-id endpoints are
typically used for EVM chain IDs.

This fixes the issue where /lanes/by-chain-id/1/43114 was incorrectly
resolving to Aptos instead of Ethereum.

Author: aelmanaa

src/lib/ccip/services/lane-data.ts

@@ -590,20 +590,40 @@ export class LaneDataService {
     }
 
     // Search through chains to find matching chain_id or selector
-    for (const [internalId, chainConfig] of Object.entries(chainsReferenceData)) {
-      if (inputKeyType === "chainId") {
-        // Try to match by numeric chain ID
+    if (inputKeyType === "chainId") {
+      // Collect all matching chains (chainId can have collisions across chain families)
+      const matches: Array<{ internalId: string; chainType: ChainType; chainFamily: ChainFamily }> = []
+
+      for (const [internalId] of Object.entries(chainsReferenceData)) {
         try {
           const supportedChain = directoryToSupportedChain(internalId)
           const chainId = getChainId(supportedChain)
           if (chainId && chainId.toString() === identifier) {
-            return internalId
+            const { chainType, chainFamily } = getChainTypeAndFamily(supportedChain)
+            matches.push({ internalId, chainType, chainFamily })
           }
         } catch {
           // Skip chains that can't be resolved
         }
-      } else if (inputKeyType === "selector") {
-        // Match by selector
+      }
+
+      if (matches.length === 0) {
+        return null
+      }
+
+      // Prioritize EVM chains since by-chain-id is typically used for EVM chain IDs
+      const evmMatch = matches.find((m) => m.chainFamily === "evm")
+      if (evmMatch) {
+        return evmMatch.internalId
+      }
+
+      // Fall back to first match if no EVM chain found
+      return matches[0].internalId
+    }
+
+    // For selector, there should be no collisions
+    for (const [internalId, chainConfig] of Object.entries(chainsReferenceData)) {
+      if (inputKeyType === "selector") {
         if (chainConfig.chainSelector === identifier) {
           return internalId
         }