[DF-22956] ensure tiingo request transform executes by removing factory wrapper (#4778)

guandali · app-token-issuer-data-feeds[bot] · web-flow · commit c3514ef14f96 · 2026-04-01T11:15:54.000-07:00
* ensure tiingo request transform executes by removing factory wrapper
---------

Co-authored-by: app-token-issuer-data-feeds[bot] &lt;134377064+app-token-issuer-data-feeds[bot]@users.noreply.github.com&gt;
diff --git a/.changeset/gentle-donkeys-film.md b/.changeset/gentle-donkeys-film.md
@@ -0,0 +1,6 @@
+---
+'@chainlink/tiingo-adapter': patch
+'chainlink/tiingo-state-adapter': patch
+---
+
+fix tiingo casing issue
diff --git a/.pnp.cjs b/.pnp.cjs
diff --git a/packages/sources/tiingo-state/package.json b/packages/sources/tiingo-state/package.json
@@ -36,7 +36,7 @@
     "typescript": "5.8.3"
   },
   "dependencies": {
-    "@chainlink/external-adapter-framework": "2.11.6",
+    "@chainlink/external-adapter-framework": "2.13.1",
     "tslib": "2.4.1"
   }
 }
diff --git a/packages/sources/tiingo-state/src/endpoint/price.ts b/packages/sources/tiingo-state/src/endpoint/price.ts
@@ -28,5 +28,5 @@ export const endpoint = new PriceEndpoint({
   transportRoutes: new TransportRoutes<BaseCryptoEndpointTypes>().register('ws', wsTransport),
   defaultTransport: 'ws',
   inputParameters: inputParameters,
-  requestTransforms: [tiingoCommonSubscriptionRequestTransform],
+  requestTransforms: [tiingoCommonSubscriptionRequestTransform()],
 })
diff --git a/packages/sources/tiingo-state/test/integration/__snapshots__/adapter.test.ts.snap b/packages/sources/tiingo-state/test/integration/__snapshots__/adapter.test.ts.snap
@@ -1,5 +1,35 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
+exports[`websocket crypto state endpoint should only subscribe once for mixed-case requests 1`] = `
+{
+  "data": {
+    "result": 1.1807636997924935,
+  },
+  "result": 1.1807636997924935,
+  "statusCode": 200,
+  "timestamps": {
+    "providerDataReceivedUnixMs": 1018,
+    "providerDataStreamEstablishedUnixMs": 1010,
+    "providerIndicatedTimeUnixMs": 1646249828102,
+  },
+}
+`;
+
+exports[`websocket crypto state endpoint should only subscribe once for mixed-case requests 2`] = `
+{
+  "data": {
+    "result": 1.1807636997924935,
+  },
+  "result": 1.1807636997924935,
+  "statusCode": 200,
+  "timestamps": {
+    "providerDataReceivedUnixMs": 1018,
+    "providerDataStreamEstablishedUnixMs": 1010,
+    "providerIndicatedTimeUnixMs": 1646249828102,
+  },
+}
+`;
+
 exports[`websocket crypto state endpoint should return error on empty base 1`] = `
 {
   "error": {
diff --git a/packages/sources/tiingo-state/test/integration/adapter.test.ts b/packages/sources/tiingo-state/test/integration/adapter.test.ts
@@ -1,12 +1,13 @@
+import { WebSocketClassProvider } from '@chainlink/external-adapter-framework/transports'
 import {
-  TestAdapter,
-  setEnvVariables,
   mockWebSocketProvider,
   MockWebsocketServer,
+  setEnvVariables,
+  TestAdapter,
 } from '@chainlink/external-adapter-framework/util/testing-utils'
 import FakeTimers from '@sinonjs/fake-timers'
+import { wsTransport } from '../../src/transport/price'
 import { mockWebsocketServer } from './fixtures'
-import { WebSocketClassProvider } from '@chainlink/external-adapter-framework/transports'
 
 describe('websocket', () => {
   let mockWsServer: MockWebsocketServer | undefined
@@ -52,6 +53,25 @@ describe('websocket', () => {
       expect(response.json()).toMatchSnapshot()
     })
 
+    it('should only subscribe once for mixed-case requests', async () => {
+      const lowercaseData = {
+        base: 'wsteth',
+        quote: 'eth',
+      }
+      const mixedCaseData = {
+        base: 'wstETH',
+        quote: 'ETH',
+      }
+
+      const response1 = await testAdapter.request(lowercaseData)
+      expect(response1.json()).toMatchSnapshot()
+
+      const response2 = await testAdapter.request(mixedCaseData)
+      expect(response2.json()).toMatchSnapshot()
+
+      expect(await wsTransport.subscriptionSet.getAll()).toHaveLength(1)
+    })
+
     it('should return error on empty data', async () => {
       const response = await testAdapter.request({})
       expect(response.statusCode).toEqual(400)
diff --git a/packages/sources/tiingo/src/endpoint/crypto-lwba.ts b/packages/sources/tiingo/src/endpoint/crypto-lwba.ts
@@ -22,5 +22,5 @@ export const endpoint = new LwbaEndpoint({
   transport,
   inputParameters: inputParameters,
   overrides: overrides.tiingo,
-  requestTransforms: [tiingoCommonSubscriptionRequestTransform],
+  requestTransforms: [tiingoCommonSubscriptionRequestTransform()],
 })
diff --git a/packages/sources/tiingo/src/endpoint/crypto.ts b/packages/sources/tiingo/src/endpoint/crypto.ts
@@ -18,5 +18,5 @@ export const endpoint = new CryptoPriceEndpoint({
   defaultTransport: 'ws',
   inputParameters: inputParameters,
   overrides: overrides.tiingo,
-  requestTransforms: [tiingoCommonSubscriptionRequestTransform],
+  requestTransforms: [tiingoCommonSubscriptionRequestTransform()],
 })
diff --git a/packages/sources/tiingo/src/endpoint/forex.ts b/packages/sources/tiingo/src/endpoint/forex.ts
@@ -33,5 +33,5 @@ export const endpoint = new ForexPriceEndpoint({
   defaultTransport: 'ws',
   inputParameters: inputParameters,
   overrides: overrides.tiingo,
-  requestTransforms: [tiingoCommonSubscriptionRequestTransform],
+  requestTransforms: [tiingoCommonSubscriptionRequestTransform()],
 })
diff --git a/packages/sources/tiingo/src/endpoint/iex.ts b/packages/sources/tiingo/src/endpoint/iex.ts
@@ -32,5 +32,5 @@ export const endpoint = new StockEndpoint({
   defaultTransport: 'ws',
   inputParameters: inputParameters,
   overrides: overrides.tiingo,
-  requestTransforms: [tiingoCommonSubscriptionRequestTransform],
+  requestTransforms: [tiingoCommonSubscriptionRequestTransform()],
 })
diff --git a/packages/sources/tiingo/src/endpoint/utils.ts b/packages/sources/tiingo/src/endpoint/utils.ts
@@ -20,8 +20,10 @@ export type BaseCryptoEndpointTypes = {
 }
 
 export function tiingoCommonSubscriptionRequestTransform() {
-  return (req: AdapterRequest<{ base: string; quote: string }>) => {
+  return (req: AdapterRequest<{ base: string; quote?: string }>) => {
     req.requestContext.data.base = req.requestContext.data.base.toLowerCase()
-    req.requestContext.data.quote = req.requestContext.data.quote.toLowerCase()
+    if (req.requestContext.data.quote) {
+      req.requestContext.data.quote = req.requestContext.data.quote.toLowerCase()
+    }
   }
 }
diff --git a/packages/sources/tiingo/test/unit/utils.test.ts b/packages/sources/tiingo/test/unit/utils.test.ts
@@ -0,0 +1,45 @@
+import { AdapterRequest } from '@chainlink/external-adapter-framework/util'
+import { tiingoCommonSubscriptionRequestTransform } from '../../src/endpoint/utils'
+
+describe('endpoint utils', () => {
+  describe('tiingoCommonSubscriptionRequestTransform', () => {
+    it('lowercases the request base and quote in place', () => {
+      const requestContextData = { base: 'EtH', quote: 'UsD' }
+      const req = {
+        requestContext: {
+          data: requestContextData,
+        },
+      } as AdapterRequest<{ base: string; quote: string }>
+
+      tiingoCommonSubscriptionRequestTransform()(req)
+
+      expect(req.requestContext.data).toEqual({ base: 'eth', quote: 'usd' })
+    })
+
+    it('leaves already lowercase pairs unchanged', () => {
+      const requestContextData = { base: 'btc', quote: 'eur' }
+      const req = {
+        requestContext: {
+          data: requestContextData,
+        },
+      } as AdapterRequest<{ base: string; quote: string }>
+
+      tiingoCommonSubscriptionRequestTransform()(req)
+
+      expect(req.requestContext.data).toEqual({ base: 'btc', quote: 'eur' })
+    })
+
+    it('lowercases base-only requests without a quote', () => {
+      const requestContextData = { base: 'USD' }
+      const req = {
+        requestContext: {
+          data: requestContextData,
+        },
+      } as AdapterRequest<{ base: string; quote?: string }>
+
+      tiingoCommonSubscriptionRequestTransform()(req)
+
+      expect(req.requestContext.data).toEqual({ base: 'usd' })
+    })
+  })
+})
diff --git a/yarn.lock b/yarn.lock
@@ -5115,7 +5115,7 @@ __metadata:
   version: 0.0.0-use.local
   resolution: "@chainlink/tiingo-state-adapter@workspace:packages/sources/tiingo-state"
   dependencies:
-    "@chainlink/external-adapter-framework": "npm:2.11.6"
+    "@chainlink/external-adapter-framework": "npm:2.13.1"
     "@sinonjs/fake-timers": "npm:9.1.2"
     "@types/jest": "npm:^29.5.14"
     "@types/node": "npm:22.14.1"

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@`
`36`	`36`	`"typescript": "5.8.3"`
`37`	`37`	`},`
`38`	`38`	`"dependencies": {`
`39`		`- "@chainlink/external-adapter-framework": "2.11.6",`
	`39`	`+ "@chainlink/external-adapter-framework": "2.13.1",`
`40`	`40`	`"tslib": "2.4.1"`
`41`	`41`	`}`
`42`	`42`	`}`