Add outsideUpdateWindow boolean to proof of reserves#4759
Draft
Add outsideUpdateWindow boolean to proof of reserves#4759
Conversation
🦋 Changeset detectedLatest commit: 6a0c945 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
cawthorne
changed the title
Remove stale meta and metricsMeta fields from snapshots that are no longer present in the adapter response.
- multi-address-list now includes windowStartMs/windowEndMs in its response, derived from when the scheduler ran and CACHE_MAX_AGE, so consumers know the validity window without needing to know the scheduler config - proof-of-reserves reserves endpoint checks for windowStartMs/windowEndMs in the protocol adapter response and emits outsideUpdateWindow if the current time is outside that window - proof-of-reserves multiReserves endpoint propagates outsideUpdateWindow from any sub-reserve instead of throwing an AdapterError
cawthorne
force-pushed
the
feature/add-ripcord-boolean-to-proof-of-reserves
branch
from
9282b81 to
ec75450
Compare
… time for windowEndMs
…urn 200 for outsideUpdateWindow
…ndMs from reserves.ts Splits the work into two PRs: - PR 1 (this branch): outsideUpdateWindow for feeds with explicit startUTC/endUTC, and multiReserves handling - PR 2 (future): automatic window signaling from multi-address-list via scheduler config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
outsideUpdateWindowto proof-of-reservesAdds a planned-pause signal to the proof-of-reserves EA so monitoring can silence alerts during known off-schedule periods, distinct from an unplanned provider outage.
Feeds that have a defined update window should include
startUTCandendUTC(formatHHMM) in their job spec. Automatic window signaling frommulti-address-list(for feeds without explicit start/end times) is out of scope here and will follow in a separate PR.Changes
proof-of-reservesreservesendpoint: ifstartUTC/endUTCare in the request and the current UTC time is outside that window, returns HTTP 503 withoutsideUpdateWindow: trueinstead of fetching balancesmultiReservesendpoint: when any sub-reserve is outside its window, returns HTTP 200/errored witherror.outsideUpdateWindow: true, preserving the existing error shapeBehaviour
multi-address-listcache empty (504)reservesoutsidestartUTC/endUTCoutsideUpdateWindow: truemultiReservessub-reserve outside windowerror.outsideUpdateWindow: true