Feat/OPDATA-6509 implied price decimals#4789
Merged
mmcallister-cll merged 10 commits intomainfrom Apr 8, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: c461a01 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mxiao-cll
reviewed
Apr 1, 2026
packages/composites/implied-price/src/endpoint/computedPrice.ts
Outdated
Show resolved
Hide resolved
dskloetc
reviewed
Apr 1, 2026
mxiao-cll
reviewed
Apr 6, 2026
mxiao-cll
reviewed
Apr 6, 2026
mxiao-cll
reviewed
Apr 6, 2026
packages/composites/implied-price-test/src/transport/computePrice.ts
Outdated
Show resolved
Hide resolved
mxiao-cll
reviewed
Apr 6, 2026
mxiao-cll
previously approved these changes
Apr 8, 2026
packages/composites/implied-price-test/src/transport/computePrice.ts
Outdated
Show resolved
Hide resolved
packages/composites/implied-price-test/src/transport/computePrice.ts
Outdated
Show resolved
Hide resolved
mxiao-cll
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #OPDATA-6509
Description
Adds optional
outputDecimals, operand1Decimals, operand2Decimalsinput params tocomputedPriceendpoint which can used to scale result to a number of output decimals based on input decimals.Changes
Steps to Test
yarn test implied-price{ "data": { "endpoint": "computedPrice", "operand1Sources": [ "data_engine" ], "operand1Input": "{\"endpoint\":\"redemptionRate-v7\",\"feedId\":\"0x0007621b6f5eb0b5bd5a8bb3d52902b3e19498ba45781e5ddf92ce7e03d7ecef\",\"resultPath\":\"exchangeRate\"}", "operand1Decimals": 18, "operand2Sources": [ "data_engine" ], "operand2Input": "{\"endpoint\":\"crypto-v3\",\"feedId\":\"0x0003fb73b717523a65721ee943f35ee7ca447dc623433c0f645126b7721c57d9\",\"resultPath\": \"price\"}", "operand2Decimals": 18, "operation": "divide", "outputDecimals": 18 } }Quality Assurance
infra-k8sconfiguration file.adapter-secretsconfiguration file.test-payload.jsonfile with relevant requests.feature/x,chore/x,release/x,hotfix/x,fix/x) or is created from Jira.