Fix ripcord bug in generic-api#4972
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 4d12c52 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
danwilliams-cll
approved these changes
May 18, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates generic-api ripcord handling so configured ripcord paths are no longer silently skipped when absent from provider responses.
Changes:
- Adjusts ripcord comparison logic in shared transport utilities.
- Updates HTTP and integration tests/snapshots for ripcord-present vs ripcord-absent behavior.
- Adds a patch changeset for the adapter.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
packages/sources/generic-api/src/transport/utils.ts |
Updates ripcord activation check logic. |
packages/sources/generic-api/test/unit/http.test.ts |
Updates and adds HTTP transport ripcord tests. |
packages/sources/generic-api/test/integration/adapter.test.ts |
Removes ripcord config from a success fixture request. |
packages/sources/generic-api/test/integration/__snapshots__/adapter.test.ts.snap |
Updates expected integration response snapshot. |
.changeset/petite-parents-win.md |
Adds patch release note. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, when the ripcord field is absent in the response, this does not cause an error even when the ripcord path is configured in the params.
The ripcord path is optional so when it's configured, it should be interpreted as expected in the response.
Changes
Steps to Test
yarn test packages/sources/generic-apigeneric-apiwithripcord.Quality Assurance
infra-k8sconfiguration file.adapter-secretsconfiguration file.test-payload.jsonfile with relevant requests.feature/x,chore/x,release/x,hotfix/x,fix/x) or is created from Jira.