Skip to content

Feat/OPDATA-6934 nobi ea#5020

Merged
mmcallister-cll merged 14 commits into
mainfrom
feat/OPDATA-6934-nobi-ea
Jun 15, 2026
Merged

Feat/OPDATA-6934 nobi ea#5020
mmcallister-cll merged 14 commits into
mainfrom
feat/OPDATA-6934-nobi-ea

Conversation

@mmcallister-cll

@mmcallister-cll mmcallister-cll commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Closes #OPDATA-6934

Description

Adds Nobi state price EA

Changes

  • Added standard plumbing & WsTransport implementation
  • Interesting part: NobiTransportManager in src/endpoint/transportManager that controls request routing based on a max number of WS subscriptions per connection and max number of connections per key (see ticket for details)

Steps to Test

  1. yarn test nobi
  2. with payloads
{
    "data": {
        "endpoint": "price",
        "base": "BTC",
        "quote": "USD"
    }
}

Set MAX_SUBSCRIPTIONS_PER_TRANSPORT sufficiently low (eg: 2) and request other common crypto pairs (eg: ETH/USD, SOL/USD) to see transport rollover

Quality Assurance

  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file.
  • If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
  • The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
  • This is related to a maximum of one Jira story or GitHub issue.
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
  • All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

@changeset-bot

changeset-bot Bot commented Jun 2, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: af1847b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@chainlink/nobi-adapter Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment thread packages/sources/nobi/docs/custom.md Outdated

@alejoberardino alejoberardino left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR with suggested approach: #5021

Comment thread packages/sources/nobi/src/transport/price.ts Outdated
Comment thread packages/sources/nobi/src/endpoint/transportManager.ts Outdated
@mmcallister-cll mmcallister-cll dismissed alejoberardino’s stale review June 12, 2026 23:15

updated with suggestions, don't want to block

@mmcallister-cll mmcallister-cll merged commit 3e6f0d7 into main Jun 15, 2026
22 checks passed
@mmcallister-cll mmcallister-cll deleted the feat/OPDATA-6934-nobi-ea branch June 15, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants