Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for scanning an entire PR via Sigscanner’s new endpoint and removes the per-commit + fallback scanner logic from the Sigscanner GitHub Actions workflow.
Changes:
- Replace per-commit verification loop with a single PR-level Sigscanner API call (with retries).
- Remove the fallback scanner step and associated commit-fetching logic.
- Tighten workflow permissions to an empty set.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| res_unverified_commits=$(echo "$response" | jq '.unverified_commits') | ||
| res_error=$(echo "$response" | jq -r '.error') | ||
|
|
There was a problem hiding this comment.
The workflow runner uses bash -e by default; if Sigscanner returns a non-JSON body (e.g., HTML error page/timeouts), the jq commands will exit non-zero and terminate the step immediately, bypassing the retry loop. Consider guarding JSON parsing (e.g., validate with jq -e and handle parse failures) so transient errors actually trigger retries.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Nice!! |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
javuto
left a comment
javuto
left a comment
There was a problem hiding this comment.
Always a pleasure to review some excellent bash! Maybe handling parsing errors with jq as suggested by Copilot wouldn't be a bad idea, just in case something other than JSON is returned. Ship it!
As discussed, Sigscanner now has an endpoint for scanning the whole PR. Also, we are removing the fallback scanner. This simplifies the workflow a lot.