ci: block chainlink-deployments-framework imports via depguard#771
Merged
Conversation
Prevent importing github.com/smartcontractkit/chainlink-deployments-framework because it would create a circular dependency with mcms.
|
gustavogama-cll
approved these changes
May 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Go lint configuration to prevent mcms from importing chainlink-deployments-framework, avoiding a circular dependency between the modules.
Changes:
- Enables the
depguardlinter. - Adds a repository-wide deny rule for
github.com/smartcontractkit/chainlink-deployments-frameworkimports.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables the
depguardlinter in golangci-lint and denies imports ofgithub.com/smartcontractkit/chainlink-deployments-framework(including subpackages). This keeps mcms from depending on chainlink-deployments-framework, which would introduce a circular dependency.Why
mcms must not import chainlink-deployments-framework because that module already depends on mcms, so adding the import would create a cycle in the dependency graph.