fix(canton): register split MCMS api/core encoders in proposal decoder#782
Conversation
Add registry tests that lock in the chainlink-canton bindings split: MCMS api choices (ScheduleBatch) and core choices (SetRoot, ExecuteOp) must resolve from separate encoders so proposal decoding keeps working after dependency bumps.
|
👋 stackman27, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
There was a problem hiding this comment.
Pull request overview
This PR adds regression tests to ensure the Canton proposal decoder’s reflection registry correctly handles the chainlink-canton MCMS bindings split (mcms/api vs mcms/core), so MCMS choices resolve against the intended encoder after #781.
Changes:
- Add a registry test that asserts
MCMS’s preferred encoder ismcms/apiwhilemcms/coreis still registered. - Add subtests verifying
ScheduleBatchcandidates come frommcms/apiandSetRoot/ExecuteOpcandidates come frommcms/core.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| func candidateTypeNames(types []reflect.Type) []string { | ||
| names := make([]string, len(types)) | ||
| for i, t := range types { | ||
| names[i] = t.String() | ||
| } | ||
| return names |
|
🤖 I have created a release *beep* *boop* --- ## [0.47.1](v0.47.0...v0.47.1) (2026-06-09) ### Bug Fixes * **canton:** register split MCMS api/core encoders in proposal decoder ([#782](#782)) ([31bac06](31bac06)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: app-token-issuer-ops-platform[bot] <275822481+app-token-issuer-ops-platform[bot]@users.noreply.github.com>
Summary
mcms/apivsmcms/core)ScheduleBatch,SetRoot, andExecuteOpresolve from the correct encoders after chore: bump chainlink-canton #781Why
chore: bump chainlink-canton (#781)does not trigger release-please; thisfix:commit should bump to0.47.1.