implemented multiclass for svc#308
Conversation
|
I messed up. My .git directory got corrupted and then I deleted it. Then I initialized a new .git folder and forced push the code but that erased the commit history. Im sorry about that. |
impl<'a, TX: Number + RealNumber, TY: Number + Ord, X: Array2<TX>, Y: Array1<TY>>
SupervisedEstimatorBorrow<'a, X, Y, SVCParameters<TX, TY, X, Y>> for SVC<'a, TX, TY, X, Y>
{
fn new() -> Self {
Self {
classes: Option::None,
instances: Option::None,
parameters: Option::None,
w: Option::None,
b: Option::None,
phantomdata: PhantomData,
}
}
fn fit(
x: &'a X,
y: &'a Y,
parameters: &'a SVCParameters<TX, TY, X, Y>,
) -> Result<Self, Failed> {
SVC::fit(x, y, parameters)
}
}``` |
|
Isnt this the API? |
|
Anyways Ill fix it. |
|
PR is ready for review. |
|
Good! all checks passed. ok, this is better but you didn't need to open a new PR, see also -> #306 (comment) This PR's code is closer to what I had in mind just: when you add a method to an existing interface, like |
|
alright Ill change it accordingly |
|
@Mec-iS fixed |
|
Good one 🚀 I will merge it when the checks have finished. It will be released with |
No description provided.