Skip to content

add serde support for XGRegressor#337

Merged
Mec-iS merged 3 commits intosmartcorelib:developmentfrom
xyzcapital:cmmartin/xgboost-serde
Nov 16, 2025
Merged

add serde support for XGRegressor#337
Mec-iS merged 3 commits intosmartcorelib:developmentfrom
xyzcapital:cmmartin/xgboost-serde

Conversation

@cmmartin
Copy link
Copy Markdown
Contributor

Fixes #325

Checklist

  • My branch is up-to-date with development branch.
  • Everything works and tested on latest stable Rust.
  • Coverage and Linting have been applied

Current behaviour

XGRegressor does not implement the Serialize/Deserialize or Debug traits

New expected behaviour

XGRegressor implements the Serialize/Deserialize and Debug traits

Change logs

@cmmartin cmmartin requested a review from Mec-iS as a code owner November 15, 2025 23:52
@Mec-iS
Copy link
Copy Markdown
Collaborator

Mec-iS commented Nov 16, 2025

Please see the failures in the CI checks. There are missing imports.
Have you tried to build your code with cargo build or run the tests with cargo test?

Please follow the guidelines in CONTRIBUTING.md

  • Formatting: run rustfmt src/*.rs to apply automatic formatting
  • Linting: clippy is used with command cargo clippy --all-features -- -Drust-2018-idioms -Dwarnings
  • Coverage (optional): tarpaulin is used with command cargo tarpaulin --out Lcov --all-features -- --test-threads 1
  • Testing: multiple test pipelines are run for different targets

@cmmartin
Copy link
Copy Markdown
Contributor Author

cmmartin commented Nov 16, 2025

My fault. I did run build and test and they worked fine but I forgot this is behind a feature flag. I updated the code and cargo test --all-features and cargo build --all-features are passing now

@Mec-iS Mec-iS merged commit 0e42a97 into smartcorelib:development Nov 16, 2025
11 checks passed
@Mec-iS
Copy link
Copy Markdown
Collaborator

Mec-iS commented Nov 16, 2025

thanks. will go on the next release 👍

1 similar comment
@Mec-iS
Copy link
Copy Markdown
Collaborator

Mec-iS commented Nov 16, 2025

thanks. will go on the next release 👍

@cmmartin cmmartin deleted the cmmartin/xgboost-serde branch November 16, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XGBoost serde support

2 participants