add serde support for XGRegressor#337
Merged
Mec-iS merged 3 commits intosmartcorelib:developmentfrom Nov 16, 2025
Merged
Conversation
Collaborator
|
Please see the failures in the CI checks. There are missing imports. Please follow the guidelines in CONTRIBUTING.md
|
Contributor
Author
|
My fault. I did run |
Mec-iS
approved these changes
Nov 16, 2025
Collaborator
|
thanks. will go on the next release 👍 |
1 similar comment
Collaborator
|
thanks. will go on the next release 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #325
Checklist
Current behaviour
XGRegressor does not implement the Serialize/Deserialize or Debug traits
New expected behaviour
XGRegressor implements the Serialize/Deserialize and Debug traits
Change logs