fix precision and recall calculations#338
Merged
Mec-iS merged 2 commits intosmartcorelib:developmentfrom Nov 24, 2025
Merged
Conversation
Collaborator
|
thanks a lot. I will review this on monday |
Mec-iS
reviewed
Nov 24, 2025
|
|
||
| let score3: f64 = Precision::new().get_score(&y_true, &y_pred); | ||
| assert!((score3 - 0.6666666666).abs() < 1e-8); | ||
| assert!((score3 - 0.5).abs() < 1e-8); |
Collaborator
There was a problem hiding this comment.
it would be nice to take the opportunity and make these statements to use approx where possible
Mec-iS
approved these changes
Nov 24, 2025
Collaborator
Mec-iS
left a comment
There was a problem hiding this comment.
💯
Hope you will stick around!
Collaborator
|
I will merge this and create a new release |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #338 +/- ##
===============================================
+ Coverage 45.23% 45.68% +0.44%
===============================================
Files 90 93 +3
Lines 7775 8034 +259
===============================================
+ Hits 3517 3670 +153
- Misses 4258 4364 +106 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #323
Checklist
Current behaviour
New expected behaviour
Change logs