Merge pull request #282 from smartdevicelink/bugfix/set-rpc-notification-range-limit

setRpcNotificationListeners only accepts notification RPCs

Author: crokita

examples/js/hello-sdl/SDL.min.js

@@ -437,6 +437,13 @@ class LifecycleConfig {
      * @returns {LifecycleConfig} - A reference to this instance to support method chaining.
      */
     setRpcNotificationListeners (listeners) {
+        // only allow notifications to be used to keep consistency with Java APIs and with the method's name
+        for (const key in listeners) {
+            const keyNumber = Number(key); // coerce to Number from String
+            if (! (keyNumber >= 0x8000 && keyNumber <= 0xFFFF)) {
+                throw new Error(`Passed in FunctionID ${keyNumber} not within notification range ${0x8000} - ${0xFFFF}`);
+            }
+        }
         this._onRpcNotificationListeners = listeners;
         return this;
     }