Merge pull request #500 from smartdevicelink/bugfix/menu-replace-running-synchronously

Fix MenuReplaceOperations being added and run synchronously

Author: renonick87

examples/node/hello-sdl/AppClient.js

@@ -105,11 +105,11 @@ class AppClient {
         this._isButtonSubscriptionRequested = false;
     }
 
-    _onConnected () {
+    async _onConnected () {
         this._managersReady = true;
         this._checkReadyState();
         const screenManager = this._sdlManager.getScreenManager();
-        
+
         // add menus
         const menuListener = new SDL.manager.screen.menu.MenuSelectionListener()
             .setOnTriggered(triggerSource => {

lib/js/src/manager/screen/_TextAndGraphicUpdateOperation.js

@@ -66,8 +66,8 @@ class _TextAndGraphicUpdateOperation extends _Task {
      * The method that causes the task to run.
      * @param {_Task} task - The task instance
      */
-    onExecute (task) {
-        this._start();
+    async onExecute (task) {
+        await this._start();
     }
     /**
      * If the task is not canceled, starts to assemble the show

lib/js/src/manager/screen/menu/_MenuConfigurationUpdateOperation.js

@@ -53,8 +53,8 @@ class _MenuConfigurationUpdateOperation extends _Task {
      * The method that causes the task to run.
      * @param {_Task} task - The task instance
      */
-    onExecute (task) {
-        this._start();
+    async onExecute (task) {
+        await this._start();
     }
 
     /**

lib/js/src/manager/screen/menu/_MenuManagerBase.js

@@ -303,7 +303,7 @@ class _MenuManagerBase extends _SubManagerBase {
     _updateMenuReplaceOperationsWithNewCurrentMenu () {
         this._taskQueue.forEach(task => {
             if (task.getName() === 'MenuReplaceOperation') {
-                task.setCurrentMenu(this._currentMenuCells);
+                task._setCurrentMenu(this._currentMenuCells);
             }
         });
     }
@@ -325,7 +325,7 @@ class _MenuManagerBase extends _SubManagerBase {
     _updateMenuReplaceOperationsWithNewMenuConfiguration () {
         this._taskQueue.forEach(task => {
             if (task.getName() === 'MenuReplaceOperation') {
-                task.setMenuConfiguration(this._currentMenuConfiguration);
+                task._setMenuConfiguration(this._currentMenuConfiguration);
             }
         });
     }

lib/js/src/manager/screen/menu/_MenuReplaceOperation.js

@@ -67,8 +67,8 @@ class _MenuReplaceOperation extends _Task {
      * The method that causes the task to run.
      * @param {_Task} task - The task instance
      */
-    onExecute (task) {
-        this._start();
+    async onExecute (task) {
+        await this._start();
     }
 
     /**

lib/js/src/manager/screen/menu/_MenuShowOperation.js

@@ -49,8 +49,8 @@ class _MenuShowOperation extends _Task {
      * The method that causes the task to run.
      * @param {_Task} task - The task instance
      */
-    onExecute (task) {
-        this._start();
+    async onExecute (task) {
+        await this._start();
     }
 
     /**