Skip to content

Commit 643c6a9

Browse files
committed
Make second arg optional for sdl manager rpc methods
1 parent a2c85b5 commit 643c6a9

7 files changed

Lines changed: 45 additions & 17 deletions

File tree

examples/js/hello-sdl/SDL.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

examples/node/hello-sdl-tcp/SDL.min.js

Lines changed: 11 additions & 3 deletions
Large diffs are not rendered by default.

examples/node/hello-sdl/SDL.min.js

Lines changed: 11 additions & 3 deletions
Large diffs are not rendered by default.

examples/webengine/hello-sdl/SDL.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/js/dist/SDL.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/js/src/manager/SdlManager.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -438,7 +438,9 @@ class SdlManager extends _SdlManagerBase {
438438
return this.sendRpcResolve(message)
439439
.then(result => {
440440
messagesRemaining--;
441-
onUpdate(result, messagesRemaining);
441+
if (typeof onUpdate === 'function') {
442+
onUpdate(result, messagesRemaining);
443+
}
442444
return result;
443445
});
444446
});
@@ -474,7 +476,9 @@ class SdlManager extends _SdlManagerBase {
474476
const result = await this.sendRpcResolve(message)
475477
.then(result => {
476478
messagesRemaining--;
477-
onUpdate(result, messagesRemaining);
479+
if (typeof onUpdate === 'function') {
480+
onUpdate(result, messagesRemaining);
481+
}
478482
return result;
479483
});
480484
resolvedRpcs.push(result);

lib/node/dist/SDL.min.js

Lines changed: 11 additions & 3 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)