Skip to content

Commit 6e3a8ca

Browse files
authored
Merge pull request #213 from smartdevicelink/bugfix/response-validate-type
Fix validateType method call
2 parents 99797b1 + bc3ade6 commit 6e3a8ca

8 files changed

Lines changed: 121 additions & 190 deletions

File tree

examples/js/hello-sdl/SDL.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

examples/node/hello-sdl-tcp/SDL.min.js

Lines changed: 36 additions & 59 deletions
Large diffs are not rendered by default.

examples/node/hello-sdl/SDL.min.js

Lines changed: 36 additions & 59 deletions
Large diffs are not rendered by default.

examples/webengine/hello-sdl/SDL.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/js/app.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -53,12 +53,12 @@ import { _PermissionManagerBase as manager_permission__PermissionManagerBase_js}
5353
import { PermissionGroupStatus as manager_permission_enums_PermissionGroupStatus_js} from './src/manager/permission/enums/PermissionGroupStatus.js';
5454
import { PermissionGroupType as manager_permission_enums_PermissionGroupType_js} from './src/manager/permission/enums/PermissionGroupType.js';
5555
import { ScreenManager as manager_screen_ScreenManager_js} from './src/manager/screen/ScreenManager.js';
56-
import { SoftButtonManager as manager_screen_SoftButtonManager_js} from './src/manager/screen/SoftButtonManager.js';
57-
import { TextAndGraphicManager as manager_screen_TextAndGraphicManager_js} from './src/manager/screen/TextAndGraphicManager.js';
58-
import { VoiceCommandManager as manager_screen_VoiceCommandManager_js} from './src/manager/screen/VoiceCommandManager.js';
5956
import { _ScreenManagerBase as manager_screen__ScreenManagerBase_js} from './src/manager/screen/_ScreenManagerBase.js';
57+
import { _SoftButtonManager as manager_screen__SoftButtonManager_js} from './src/manager/screen/_SoftButtonManager.js';
6058
import { _SoftButtonManagerBase as manager_screen__SoftButtonManagerBase_js} from './src/manager/screen/_SoftButtonManagerBase.js';
59+
import { _TextAndGraphicManager as manager_screen__TextAndGraphicManager_js} from './src/manager/screen/_TextAndGraphicManager.js';
6160
import { _TextAndGraphicManagerBase as manager_screen__TextAndGraphicManagerBase_js} from './src/manager/screen/_TextAndGraphicManagerBase.js';
61+
import { _VoiceCommandManager as manager_screen__VoiceCommandManager_js} from './src/manager/screen/_VoiceCommandManager.js';
6262
import { _VoiceCommandManagerBase as manager_screen__VoiceCommandManagerBase_js} from './src/manager/screen/_VoiceCommandManagerBase.js';
6363
import { SoftButtonObject as manager_screen_utils_SoftButtonObject_js} from './src/manager/screen/utils/SoftButtonObject.js';
6464
import { SoftButtonState as manager_screen_utils_SoftButtonState_js} from './src/manager/screen/utils/SoftButtonState.js';
@@ -499,12 +499,12 @@ const SDL = {
499499
},
500500
screen: {
501501
ScreenManager: manager_screen_ScreenManager_js,
502-
SoftButtonManager: manager_screen_SoftButtonManager_js,
503-
TextAndGraphicManager: manager_screen_TextAndGraphicManager_js,
504-
VoiceCommandManager: manager_screen_VoiceCommandManager_js,
505502
_ScreenManagerBase: manager_screen__ScreenManagerBase_js,
503+
_SoftButtonManager: manager_screen__SoftButtonManager_js,
506504
_SoftButtonManagerBase: manager_screen__SoftButtonManagerBase_js,
505+
_TextAndGraphicManager: manager_screen__TextAndGraphicManager_js,
507506
_TextAndGraphicManagerBase: manager_screen__TextAndGraphicManagerBase_js,
507+
_VoiceCommandManager: manager_screen__VoiceCommandManager_js,
508508
_VoiceCommandManagerBase: manager_screen__VoiceCommandManagerBase_js,
509509
utils: {
510510
SoftButtonObject: manager_screen_utils_SoftButtonObject_js,

lib/js/dist/SDL.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/js/src/rpc/RpcResponse.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ class RpcResponse extends RpcMessage {
9595
* @returns {RpcResponse} - A reference of this class to support method chaining.
9696
*/
9797
setResultCode (resultCode) {
98-
this.validateType(Result, resultCode);
98+
this._validateType(Result, resultCode);
9999

100100
this.setParameter(RpcResponse.KEY_RESULT_CODE, resultCode);
101101
return this;

lib/node/dist/SDL.min.js

Lines changed: 36 additions & 59 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)