remove unnecessary catch after sendRpcResolve

Author: renonick87

lib/js/src/manager/SystemCapabilityManager.js

@@ -471,7 +471,6 @@ class SystemCapabilityManager extends _SubManagerBase {
 
     /**
      * Sends a request to core for the capability, instead of checking cached capabilities
-     * @deprecated since version 1.1. Use sendRpcResolve instead
      * @param {SystemCapabilityType} systemCapabilityType - A SystemCapabilityType enum value.
      * @returns {Promise} - Promise returning either the capability Object or null if not found
      */
@@ -511,47 +510,6 @@ class SystemCapabilityManager extends _SubManagerBase {
         return this.getCapability(systemCapabilityType, retrievedCapability);
     }
 
-    /**
-     * Sends a request to core for the capability, instead of checking cached capabilities
-     * @param {SystemCapabilityType} systemCapabilityType - A SystemCapabilityType enum value.
-     * @returns {Promise} - Promise returning either the capability Object or null if not found
-     */
-    async updateCapabilityResolve (systemCapabilityType) {
-        // don't bother getting a capability if it isn't queryable
-        const getCapabilityMethodName = this._getCapabilityMethodForType(systemCapabilityType);
-        if (getCapabilityMethodName === null) {
-            console.error(`The systemCapabilityType ${systemCapabilityType} cannot be queried for`);
-            return null;
-        }
-
-        const request = new GetSystemCapability()
-            .setSystemCapabilityType(systemCapabilityType);
-
-        if (this._lifecycleManager === null) {
-            return null;
-        }
-
-        const response = await this._lifecycleManager.sendRpcResolve(request)
-            .catch(err => {
-                if (err instanceof RpcResponse) {
-                    console.error(`GetSystemCapability for type ${systemCapabilityType} returned with response code ${err.getResultCode()}`);
-                } else {
-                    console.error(new Error(err));
-                }
-                return null;
-            });
-
-        if (response === null) {
-            return null;
-        }
-
-        // invoke the correct get capability method
-        const retrievedCapability = response.getSystemCapability()[getCapabilityMethodName]();
-        this._setCapability(systemCapabilityType, retrievedCapability);
-        // get the capability back through this method, because it may have changed the output
-        return this.getCapability(systemCapabilityType, retrievedCapability);
-    }
-
     /**
      * Add an OnSystemCapabilityListener function.
      * @param {SystemCapabilityType} systemCapabilityType - A SystemCapabilityType enum value.

lib/js/src/manager/lifecycle/_LifecycleManager.js

@@ -109,10 +109,7 @@ class _LifecycleManager {
 
             if (serviceType === _ServiceType.RPC) {
                 if (this._lifecycleConfig !== null && this._lifecycleConfig !== undefined) {
-                    this.sendRpcResolve(this._createRegisterAppInterface())
-                        .catch(() => {
-                            // avoids uncaught error
-                        });
+                    this.sendRpcResolve(this._createRegisterAppInterface());
                 }
             }
         });

lib/js/src/manager/screen/_SoftButtonManagerBase.js

@@ -318,8 +318,7 @@ class _SoftButtonManagerBase extends _SubManagerBase {
                 show.setSoftButtons(this._createSoftButtonsForCurrentState());
             }
 
-            const response = await this._lifecycleManager.sendRpcResolve(show)
-                .catch(err => err);
+            const response = await this._lifecycleManager.sendRpcResolve(show);
 
             if (!response.getSuccess()) {
                 console.error(response);