Fix MenuReplaceOperations being added and run synchronously

Author: renonick87

examples/js/hello-sdl/index.html

@@ -152,7 +152,7 @@
 
                 const cellList = [mainCell1, mainCell2];
 
-                screenManager.setMenu(cellList);
+                await screenManager.setMenu(cellList);
             }
 
             async _onHmiStatusListener (onHmiStatus) {

examples/node/hello-sdl-tcp/index.js

@@ -147,7 +147,7 @@ class AppClient {
 
         const cellList = [mainCell1, mainCell2];
 
-        screenManager.setMenu(cellList);
+        await screenManager.setMenu(cellList);
     }
 
     async _onHmiStatusListener (onHmiStatus) {

examples/node/hello-sdl/AppClient.js

@@ -105,11 +105,11 @@ class AppClient {
         this._isButtonSubscriptionRequested = false;
     }
 
-    _onConnected () {
+    async _onConnected () {
         this._managersReady = true;
         this._checkReadyState();
         const screenManager = this._sdlManager.getScreenManager();
-        
+
         // add menus
         const menuListener = new SDL.manager.screen.menu.MenuSelectionListener()
             .setOnTriggered(triggerSource => {
@@ -135,7 +135,7 @@ class AppClient {
 
         const cellList = [mainCell1, mainCell2];
 
-        screenManager.setMenu(cellList);
+        await screenManager.setMenu(cellList);
     }
 
     _onHmiStatusListener (onHmiStatus) {

examples/webengine/hello-sdl/index.html

@@ -157,7 +157,7 @@
 
                 const cellList = [mainCell1, mainCell2];
 
-                screenManager.setMenu(cellList);
+                await screenManager.setMenu(cellList);
             }
 
             async _onSystemCapabilityUpdatedRpcListener (capabilityMessage) {

lib/js/src/manager/screen/_ScreenManagerBase.js

@@ -666,8 +666,8 @@ class _ScreenManagerBase extends _SubManagerBase {
      * Note: the manager will store a deep copy the menuCells internally to be able to handle future updates correctly
      * @param {MenuCell[]} menuCells - The menu cells that are to be sent to the head unit, including their sub-cells.
      */
-    setMenu (menuCells) {
-        this._menuManagerBase._setMenuCells(menuCells);
+    async setMenu (menuCells) {
+        await this._menuManagerBase._setMenuCells(menuCells);
     }
 
     /**

lib/js/src/manager/screen/menu/_MenuManagerBase.js

@@ -142,34 +142,38 @@ class _MenuManagerBase extends _SubManagerBase {
     /**
      * Creates and sends all associated Menu RPCs
      * @param {MenuCell[]} cells - The menu cells that are to be sent to the head unit, including their sub-cells.
+     * @returns {Promise} - A Promise that resolves to whether the operation was successful
      */
     _setMenuCells (cells = []) {
         if (cells === null) {
             console.error('MenuManagerBase - Cells list is null. Skipping...');
-            return;
+            return Promise.resolve(true);
         }
 
         if (!this._menuCellsAreUnique(cells, [])) {
             console.error('MenuManagerBase - Not all set menu cells are unique, but that is required');
-            return;
+            return Promise.resolve(false);
         }
 
         // Create a deep copy of the list so future changes by developers don't affect the algorithm logic
         this._menuCells = cells.map(cell => cell.clone());
         const isDynamicMenuUpdateActiveBoolean = this._isDynamicMenuUpdateActive(this._dynamicMenuUpdatesMode, this._displayType);
 
-        const operation = new _MenuReplaceOperation(this._lifecycleManager, this._fileManager, this._windowCapability,
-            this._currentMenuConfiguration, this._currentMenuCells, this._menuCells, isDynamicMenuUpdateActiveBoolean, new _MenuManagerCompletionListener()
-                .setOnComplete((success, currentMenuCells) => {
-                    this._currentMenuCells = currentMenuCells;
-                    this._updateMenuReplaceOperationsWithNewCurrentMenu();
-                    console.log('MenuManagerBase - Finished updating menu');
-                })
-        );
-
-        // Cancel previous MenuReplaceOperations
-        this._cancelAllTasks('MenuReplaceOperation');
-        this._addTask(operation);
+        return new Promise((resolve) => {
+            const operation = new _MenuReplaceOperation(this._lifecycleManager, this._fileManager, this._windowCapability,
+                this._currentMenuConfiguration, this._currentMenuCells, this._menuCells, isDynamicMenuUpdateActiveBoolean, new _MenuManagerCompletionListener()
+                    .setOnComplete((success, currentMenuCells) => {
+                        this._currentMenuCells = currentMenuCells;
+                        this._updateMenuReplaceOperationsWithNewCurrentMenu();
+                        console.log('MenuManagerBase - Finished updating menu');
+                        resolve(success);
+                    })
+            );
+
+            // Cancel previous MenuReplaceOperations
+            this._cancelAllTasks('MenuReplaceOperation');
+            this._addTask(operation);
+        });
     }
 
     /**