Merge pull request #423 from smartdevicelink/bugfix/cloning-old-permissions

PermissionManager should convert old permissions to RPCStructs after cloning them

Author: renonick87

lib/js/src/manager/permission/_PermissionManagerBase.js

@@ -37,6 +37,7 @@ import { PermissionGroupStatus } from './enums/PermissionGroupStatus.js';
 import { PermissionStatus } from './PermissionStatus.js';
 import { FunctionID } from '../../rpc/enums/FunctionID.js';
 import { PredefinedWindows } from '../../rpc/enums/PredefinedWindows.js';
+import { PermissionItem } from '../../rpc/structs/PermissionItem.js';
 
 class _PermissionManagerBase extends _SubManagerBase {
     /**
@@ -64,7 +65,11 @@ class _PermissionManagerBase extends _SubManagerBase {
 
         this._onPermissionsChangeListener = (notification) => {
             const permissionItems = notification.getPermissionItem();
-            const previousPermissionItems = JSON.parse(JSON.stringify(this._currentPermissionItems));
+            const previousPermissionItemsJson = JSON.parse(JSON.stringify(this._currentPermissionItems));
+            const previousPermissionItems = {};
+            Object.entries(previousPermissionItemsJson).map(([functionId, permissionObject]) => {
+                previousPermissionItems[functionId] = new PermissionItem(permissionObject._parameters);
+            });
             const requireEncryptionAppLevel = notification.getRequireEncryption();
 
             // clear the entire _encryptionRequiredRpcs array to be repopulated