Merge pull request #549 from smartdevicelink/bugfix/sdlartwork-clone

crokita · web-flow · commit 95fd5e75d9d2 · 2022-07-18T09:54:03.000-04:00
Do not clone _imageRPC with SdlArtwork
diff --git a/lib/js/src/manager/file/filetypes/SdlArtwork.js b/lib/js/src/manager/file/filetypes/SdlArtwork.js
@@ -125,9 +125,9 @@ class SdlArtwork extends SdlFile {
     clone () {
         const clonedParams = Object.assign({}, this); // shallow copy
 
-        if (clonedParams._imageRPC !== null) {
-            clonedParams._imageRPC = Object.assign(new Image(), clonedParams._imageRPC);
-        }
+        // do not clone the _imageRPC parameter. let getImageRPC regenerate the property if the manager needs it
+        delete clonedParams._imageRPC;
+
         return Object.assign(new SdlArtwork(), clonedParams);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -125,9 +125,9 @@ class SdlArtwork extends SdlFile {`
`125`	`125`	`clone () {`
`126`	`126`	`const clonedParams = Object.assign({}, this); // shallow copy`
`127`	`127`
`128`		`- if (clonedParams._imageRPC !== null) {`
`129`		`- clonedParams._imageRPC = Object.assign(new Image(), clonedParams._imageRPC);`
`130`		`- }`
	`128`	`+ // do not clone the _imageRPC parameter. let getImageRPC regenerate the property if the manager needs it`
	`129`	`+ delete clonedParams._imageRPC;`
	`130`	`+`
`131`	`131`	`return Object.assign(new SdlArtwork(), clonedParams);`
`132`	`132`	`}`
`133`	`133`	`}`