Skip to content

Commit 973a448

Browse files
committed
Fix return values of _setMenuCells
1 parent fbb3f8f commit 973a448

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

lib/js/src/manager/screen/menu/_MenuManagerBase.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -142,17 +142,16 @@ class _MenuManagerBase extends _SubManagerBase {
142142
/**
143143
* Creates and sends all associated Menu RPCs
144144
* @param {MenuCell[]} cells - The menu cells that are to be sent to the head unit, including their sub-cells.
145-
* @returns {Promise} - A Promise that resolves to whether the operation was successful
146145
*/
147146
_setMenuCells (cells = []) {
148147
if (cells === null) {
149148
console.error('MenuManagerBase - Cells list is null. Skipping...');
150-
return Promise.resolve(true);
149+
return;
151150
}
152151

153152
if (!this._menuCellsAreUnique(cells, [])) {
154153
console.error('MenuManagerBase - Not all set menu cells are unique, but that is required');
155-
return Promise.resolve(false);
154+
return;
156155
}
157156

158157
// Create a deep copy of the list so future changes by developers don't affect the algorithm logic

0 commit comments

Comments
 (0)