Skip to content

Commit e060b96

Browse files
authored
Merge pull request #390 from smartdevicelink/bugfix/scm-passing-null
Perform null checks for setting image and text fields
2 parents 1e9ca69 + cb0963b commit e060b96

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

lib/js/src/manager/SystemCapabilityManager.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -726,8 +726,12 @@ class SystemCapabilityManager extends _SubManagerBase {
726726
const convertedCapabilities = new DisplayCapabilities();
727727
convertedCapabilities.setDisplayType(DisplayType.SDL_GENERIC); // deprecated but it is mandatory...
728728
convertedCapabilities.setDisplayName(displayName);
729-
convertedCapabilities.setTextFields(defaultMainWindow.getTextFields());
730-
convertedCapabilities.setImageFields(defaultMainWindow.getImageFields());
729+
if (defaultMainWindow.getTextFields() !== null && defaultMainWindow.getTextFields() !== undefined) {
730+
convertedCapabilities.setTextFields(defaultMainWindow.getTextFields());
731+
}
732+
if (defaultMainWindow.getImageFields() !== null && defaultMainWindow.getImageFields() !== undefined) {
733+
convertedCapabilities.setImageFields(defaultMainWindow.getImageFields());
734+
}
731735
convertedCapabilities.setTemplatesAvailable(defaultMainWindow.getTemplatesAvailable());
732736
convertedCapabilities.setNumCustomPresetsAvailable(defaultMainWindow.getNumCustomPresetsAvailable());
733737
convertedCapabilities.setMediaClockFormats([]); // mandatory field but allows empty array

0 commit comments

Comments
 (0)