Skip to content

Commit fa1c7de

Browse files
committed
Update rpc_spec, .gitmodules, some JSs in accordance with code review at #357.
1 parent 1d97a2d commit fa1c7de

4 files changed

Lines changed: 4 additions & 4 deletions

File tree

.gitmodules

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
[submodule "lib/rpc_spec"]
22
path = lib/rpc_spec
3-
url = https://github.com/shiniwat/rpc_spec.git
4-
branch = feature/issue-222
3+
url = https://github.com/smartdevicelink/rpc_spec.git

lib/js/src/streaming/video/_VideoStreamingParameters.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ class _VideoStreamingParameters {
105105
this._format = formats[0];
106106
}
107107
const fps = capability.getPreferredFPS();
108-
if (fps != null) {
108+
if (fps !== null) {
109109
this._frameRate = fps;
110110
}
111111
}

tests/node/streaming/video/VideoStreamingParametersTest.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@ describe('VideoStreamingParametersTest', function () {
9494
capability.setPreferredFPS(15);
9595
params.update(capability);
9696
Validator.assertEquals(params.getFormat(), format);
97+
Validator.assertEquals(params.getFrameRate(), 15);
9798

9899
done();
99100
});

0 commit comments

Comments
 (0)