Fix wrong reference in upload operation and update unit tests

Author: renonick87

lib/js/src/manager/file/_FileManagerBase.js

@@ -170,8 +170,6 @@ class _FileManagerBase extends _SubManagerBase {
                 this._deleteRemoteFileWithNamePrivate(fileName, (success, bytesAvailable, fileNames, errorMessage) => {
                     if (!success) {
                         failedDeletes.set(fileName, errorMessage);
-                    } else {
-                        this._bytesAvailable = bytesAvailable;
                     }
                     resolve();
                 });

lib/js/src/manager/file/_UploadFileOperation.js

@@ -47,9 +47,11 @@ class _UploadFileOperation extends _Task {
         }
 
         if (!this._fileManager.fileNeedsUpload(file)) {
-            const errorMessage = this.fileManagerCannotOverwriteError;
+            const errorMessage = _UploadFileOperation.fileManagerCannotOverwriteError;
             console.log(errorMessage);
-            this._fileWrapper.getCompletionListener(false, null, null, errorMessage);
+            if (typeof this._fileWrapper.getCompletionListener() === 'function') {
+                this._fileWrapper.getCompletionListener()(false, null, null, errorMessage);
+            }
             return this.onFinished();
         }
 

tests/managers/file/UploadFileOperationTests.js

@@ -11,8 +11,6 @@ const Validator = require('../../Validator');
 module.exports = function (appClient) {
     const sdlManager = appClient._sdlManager;
     const fileManager = sdlManager.getFileManager();
-    const uploadOverwriteFailure = 'File is already on the head unit, aborting upload operation';
-
     describe('UploadFileOperationTests', function () {
         describe('when the file is already on the head unit', function () {
             describe('when not overwriting', function () {
@@ -28,7 +26,7 @@ module.exports = function (appClient) {
                         Validator.assertNull(bytesAvailable);
                         Validator.assertNull(fileNames);
                         Validator.assertNotNullUndefined(errorMessage);
-                        Validator.assertEquals(errorMessage, uploadOverwriteFailure);
+                        Validator.assertEquals(errorMessage, SDL.manager.file._UploadFileOperation.fileManagerCannotOverwriteError);
                     });
                     const operation = new SDL.manager.file._UploadFileOperation(sdlManager._lifecycleManager, sdlManager.getFileManager(), testFileWrapper);
                     await operation._start();