fix(deps): support graphql 16 and 17 (#503)

* fix(deps): support graphql 16 and 17

Widen the graphql range to ^16.12.0 || ^17.0.0 (dependency + new
peerDependency) and adjust the code to the v16-and-v17 API intersection:

- errors.ts: use the object-form GraphQLError constructor (the positional
  form was removed in v17).
- resolvers: read info.variableValues via a getVariableValues() helper that
  handles both v16's plain record and v17's { sources, coerced } shape.

Verified: build + lint + full jest suite green against both graphql@16.14.2
and graphql@17.0.1.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* chore: adjust matrix

* huebscher

* debug

* debug

* idefix

* upgrade packages

* fix: green CI after package upgrades (lint + tsc build)

The 'upgrade packages' commit regenerated the lockfile, which pulled:
- @typescript-eslint 8.63 — now flags the pre-existing union
  `Knex.RawBinding | Knex.ValueDict` in permissions/check.ts as
  no-redundant-type-constituents (RawBinding already subsumes it / collapses
  to any). Neither caller passes a ValueDict, so narrow the param to
  Knex.RawBinding.
- @types/node 25.9.4 (was 25.3.3) — no longer auto-included into the build
  tsconfig's global scope, so tsc fails with TS2591 (Cannot find name
  'process'/'http'/'crypto'). Add "types": ["node"] to tsconfig.json as TS
  itself recommends; version-independent and the build only needs node globals.

Both issues fail 'npm run test' on every matrix cell (lint runs first, so the
graphql-16/pg14 cell that finished first is what CI reported; fail-fast
cancelled the rest). Verified green under graphql 16 and 17.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* cleanup

* types

---------

Co-authored-by: Nicola Marcacci Rossi <nicola@smartive.ch>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: Moreno Feltscher <moreno@smartive.ch>

Author: 4 people

.github/workflows/testing.yml

@@ -22,7 +22,12 @@ jobs:
           - version: 16
           - version: 17
           - version: 18
-    name: test and build package (node ${{ matrix.node.version }}, postgres ${{ matrix.postgres.version }})
+        graphql:
+          - version: '16'
+            spec: '^16.12.0'
+          - version: '17'
+            spec: '^17.0.0'
+    name: test and build package (node ${{ matrix.node.version }}, postgres ${{ matrix.postgres.version }}, graphql ${{ matrix.graphql.version }})
     runs-on: ubuntu-latest
     container: node:${{ matrix.node.version }}-alpine
 
@@ -47,6 +52,10 @@ jobs:
         uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
       - name: Install dependencies
         run: npm ci
+      - name: Install graphql ${{ matrix.graphql.spec }}
+        # --legacy-peer-deps: @graphql-codegen/* still caps its graphql peer at
+        # ^16, so installing graphql 17 otherwise trips ERESOLVE (see PR #503).
+        run: npm install graphql@${{ matrix.graphql.spec }} --legacy-peer-deps
       - name: Lint
         run: npm run lint
       - name: Run tests

package-lock.json

@@ -43,25 +43,23 @@
     "access": "public"
   },
   "dependencies": {
-    "@graphql-codegen/add": "^7.0.0",
-    "@graphql-codegen/cli": "^7.0.0",
-    "@graphql-codegen/typescript": "^6.0.0",
-    "@graphql-codegen/typescript-operations": "^6.0.0",
-    "@graphql-codegen/typescript-resolvers": "^6.0.0",
-    "@types/node": "^25.0.9",
+    "@graphql-codegen/add": "^7.1.0",
+    "@graphql-codegen/cli": "^7.2.0",
+    "@graphql-codegen/typescript": "^6.1.0",
+    "@graphql-codegen/typescript-operations": "^6.1.0",
+    "@graphql-codegen/typescript-resolvers": "^6.1.0",
     "code-block-writer": "^13.0.3",
     "dayjs": "^1.11.19",
     "dotenv": "^17.2.3",
-    "graphql": "^16.12.0",
     "inflection": "^3.0.2",
-    "knex": "^3.0.1",
     "knex-schema-inspector": "^3.1.0",
     "lodash": "^4.17.21",
     "luxon": "^3.7.2",
     "pg": "^8.17.1",
     "ts-morph": "^28.0.0"
   },
   "peerDependencies": {
+    "graphql": "^16.12.0 || ^17.0.0",
     "knex": "^3.0.1"
   },
   "devDependencies": {
@@ -70,14 +68,17 @@
     "@types/jest": "30.0.0",
     "@types/lodash": "4.17.24",
     "@types/luxon": "3.7.2",
+    "@types/node": "26.1.0",
     "@types/pg": "8.20.0",
     "conventional-changelog-conventionalcommits": "10.2.0",
     "create-ts-index": "1.14.0",
     "del-cli": "7.0.0",
     "esbuild": "0.28.1",
     "eslint": "9.39.4",
     "eslint-import-resolver-typescript": "4.4.5",
+    "graphql": "17.0.2",
     "jest": "30.4.2",
+    "knex": "3.0.1",
     "mock-knex": "0.4.13",
     "prettier": "3.9.4",
     "ts-jest": "29.4.11",

package.json

@@ -1,9 +1,9 @@
-import { GraphQLError as GQLError } from 'graphql';
+import { GraphQLError as GQLError, GraphQLErrorOptions } from 'graphql';
 import { PermissionAction } from './permissions/generate';
 
 export class GraphQLError extends GQLError {
-  constructor(message: string, extensions: ConstructorParameters<typeof GQLError>[6]) {
-    super(message, undefined, undefined, undefined, undefined, undefined, extensions);
+  constructor(message: string, extensions: GraphQLErrorOptions['extensions']) {
+    super(message, { extensions });
   }
 }
 

src/errors.ts

@@ -3,7 +3,7 @@ import { Kind } from 'graphql';
 import { summonByKey } from '../models/utils';
 import { Value } from '../values';
 import { FieldResolverNode } from './node';
-import { Maybe, VariableValues } from './utils';
+import { getVariableValues, Maybe, VariableValues } from './utils';
 
 export type Where = Record<string, Value>;
 
@@ -70,7 +70,7 @@ export const normalizeArguments = (node: FieldResolverNode) => {
   const normalizedArguments: NormalizedArguments = {};
   if (node.field.arguments) {
     for (const argument of node.field.arguments) {
-      const rawValue = getRawValue(argument.value, node.ctx.info.variableValues);
+      const rawValue = getRawValue(argument.value, getVariableValues(node.ctx.info));
       const normalizedValue = normalizeValue(
         rawValue,
         summonByKey(node.fieldDefinition.arguments || [], 'name.value', argument.name.value).type,

src/resolvers/arguments.ts

@@ -5,6 +5,7 @@ import type {
   FragmentDefinitionNode,
   FragmentSpreadNode,
   GraphQLObjectType,
+  GraphQLResolveInfo,
   GraphQLSchema,
   InlineFragmentNode,
   TypeNode,
@@ -23,6 +24,18 @@ export const TYPE_ALIAS = 'TYPE';
 
 export type VariableValues = Record<string, Value>;
 
+// graphql v16 exposes `info.variableValues` as a plain `{ [name]: value }` record,
+// whereas graphql v17 wraps it as `{ sources, coerced }` with the runtime values under
+// `coerced`. Read both shapes so resolvers work against either major version.
+export const getVariableValues = (info: GraphQLResolveInfo): VariableValues => {
+  const variableValues = info.variableValues as unknown;
+  if (variableValues && typeof variableValues === 'object' && 'coerced' in variableValues && 'sources' in variableValues) {
+    return (variableValues as { coerced: VariableValues }).coerced;
+  }
+
+  return variableValues as VariableValues;
+};
+
 export const getTypeName = (t: TypeNode): string => {
   switch (t.kind) {
     case 'ListType':

src/resolvers/utils.ts

@@ -7,6 +7,7 @@
     "sourceMap": true,
     "declaration": true,
     "target": "esnext",
+    "types": ["node"],
     "moduleResolution": "bundler",
     "skipLibCheck": true,
     "strictNullChecks": true,