Import and integrate LiquidTestReports.Core as an external component#12
Merged
Conversation
- Configure PropertyGroup/ItemGroup in .csproj for license bundle packaging - Add LICENSE_BUNDLE.txt, Directory.Build.props and Directory.Build.targets - Add src/external/README.md and LiquidTestReports.Core.spdx.json - Create src/external/LiquidTestReports.Core/.gitkeep as a directory placeholder - Note: The actual embedded source code files are not included in this commit
- Clone and check out the upstream repository at branch 'master' and commit 1f39c20cec7aa06f50f88843ebe99f58f7ead3c5. - Copy the contents of 'src/LiquidTestReports.Core' into 'src/external/LiquidTestReports.Core'. - Exclude the following files from the import: - src/LiquidTestReports.Core/Mappers/JUnitMapper.cs (JUnit is unsupported in this implementation) - src/LiquidTestReports.Core/Resources/LiquidTestReports.Core.Junit.cs (JUnit is unsupported in this implementation) - src/LiquidTestReports.Core/Resources/jenkins-junit.xsd (Origin and license are unverified) - src/LiquidTestReports.Core/Resources/vstst.xsd (Origin and license are unverified)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request imports the source code of
LiquidTestReports.Coreinto the repository as an external component, enabling custom modifications and local maintenance for internal implementation purposes.Description
Background and Rationale:
The upstream repository (
kurtmkurtm/LiquidTestReports) has been inactive for an extended period, preventing necessary bug fixes and maintenance updates from being integrated via standard upstream contributions. To resolve this restriction, the source files fromsrc/LiquidTestReports.Corehave been vendored directly into this repository.Infrastructure and Packaging Configuration:
src/external/to compile the component as a separate assembly, which is referenced exclusively via aProjectReferencewithPrivateAssets="all".LiquidTestReports.Core.dll) is bundled internally within the host project's final NuGet package (Smdn.Extensions.Mtp.LiquidTestReports), avoiding any exposure of the component in the public package dependency list.src/external/Directory.Build.propsis introduced to suppress compiler warnings originating from the upstream code and clear inherited default packaging configurations.Licensing and Compliance:
src/external/LiquidTestReports.Core.LICENSE.LICENSE_BUNDLE.txt) containing both the primary MIT License and the third-party BSD 2-Clause License is created to be embedded directly into the root of the generated NuGet package.src/external/LiquidTestReports.Core.spdx.jsonusing SPDX v2.3 specifications.Considerations
Scope of the Imported Source Code:
The baseline code is fetched from branch
masterat commit1f39c20cec7aa06f50f88843ebe99f58f7ead3c5. To minimize the footprint and avoid legal uncertainties, the following files have been intentionally excluded from the import:JUnitMapper.csandLiquidTestReports.Core.Junit.cs: Excluded because JUnit functionality is unsupported in this host implementation.jenkins-junit.xsdandvstst.xsd: Excluded because the precise origins and distribution licenses of these schema files are unverified.Maintenance Strategy:
Since the component is disconnected from the upstream repository, any future bug fixes or updates to this integrated component must be managed locally within the
src/external/LiquidTestReports.Coredirectory.