Skip to content

Commit 1eefb5e

Browse files
committed
Fix spotless and address kstich's comments
1 parent 61c8fb7 commit 1eefb5e

1 file changed

Lines changed: 12 additions & 11 deletions

File tree

  • aws/aws-service-bundler/src/main/java/software/amazon/smithy/java/aws/servicebundle/bundler

aws/aws-service-bundler/src/main/java/software/amazon/smithy/java/aws/servicebundle/bundler/AwsServiceBundler.java

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
import java.util.Map;
1919
import java.util.Objects;
2020
import java.util.Set;
21-
2221
import software.amazon.smithy.aws.traits.ServiceTrait;
2322
import software.amazon.smithy.aws.traits.auth.SigV4Trait;
2423
import software.amazon.smithy.awsmcp.model.AwsServiceMetadata;
@@ -88,18 +87,20 @@ public AwsServiceBundler(String serviceName, Set<String> exposedOperations, Set<
8887
private static ServiceShape findService(Model model, String name) {
8988
var nameLower = name.toLowerCase(Locale.ROOT);
9089
for (var service : model.getServiceShapes()) {
91-
var sdkTrait = service.getTrait(ServiceTrait.class);
92-
if (sdkTrait.isPresent()) {
93-
if (sdkTrait.get().getSdkId().toLowerCase(Locale.ROOT).contains(nameLower)) {
94-
return service;
95-
}
90+
if (service.hasTrait(ServiceTrait.ID) && service.expectTrait(ServiceTrait.class)
91+
.getSdkId()
92+
.toLowerCase(Locale.ROOT)
93+
.contains(nameLower)) {
94+
return service;
9695
}
97-
var sigV4 = service.getTrait(SigV4Trait.class);
98-
if (sigV4.isPresent()) {
99-
if (sigV4.get().getName().toLowerCase(Locale.ROOT).contains(nameLower)) {
100-
return service;
101-
}
96+
if (service.hasTrait(SigV4Trait.ID)
97+
&& service.expectTrait(SigV4Trait.class)
98+
.getName()
99+
.toLowerCase(Locale.ROOT)
100+
.contains(nameLower)) {
101+
return service;
102102
}
103+
103104
}
104105
throw new RuntimeException("couldn't find service with name " + name);
105106
}

0 commit comments

Comments
 (0)