Trim down interfaces and cleanup docs

Author: mtdowling

aws/client/aws-client-awsjson/src/main/java/software/amazon/smithy/java/aws/client/awsjson/AwsJsonProtocol.java

@@ -79,7 +79,7 @@ public <I extends SerializableStruct, O extends SerializableStruct> HttpRequest
             SmithyUri endpoint
     ) {
         var target = service.getName() + "." + operation.schema().id().getName();
-        var builder = HttpRequest.create(requestFactory(context));
+        var builder = HttpRequest.create();
         builder.setMethod("POST");
         builder.setUri(endpoint);
         if (operation.inputEventBuilderSupplier() != null) {

aws/client/aws-client-awsquery/src/main/java/software/amazon/smithy/java/aws/client/awsquery/AwsQueryClientProtocol.java

@@ -80,7 +80,7 @@ public <I extends SerializableStruct, O extends SerializableStruct> HttpRequest
 
         ByteBuffer body = serializer.finish();
 
-        return HttpRequest.create(requestFactory(context))
+        return HttpRequest.create()
                 .setMethod("POST")
                 .setUri(endpoint)
                 .setHeader(HeaderName.CONTENT_TYPE, CONTENT_TYPE)

aws/client/aws-client-awsquery/src/main/java/software/amazon/smithy/java/aws/client/awsquery/Ec2QueryClientProtocol.java

@@ -80,7 +80,7 @@ public <I extends SerializableStruct, O extends SerializableStruct> HttpRequest
 
         ByteBuffer body = serializer.finish();
 
-        return HttpRequest.create(requestFactory(context))
+        return HttpRequest.create()
                 .setMethod("POST")
                 .setUri(endpoint)
                 .setHeader(HeaderName.CONTENT_TYPE, CONTENT_TYPE)

aws/client/aws-client-restjson/src/main/java/software/amazon/smithy/java/aws/client/restjson/RestJsonClientProtocol.java

@@ -72,8 +72,7 @@ public <I extends SerializableStruct, O extends SerializableStruct> HttpRequest
                 .shapeValue(input)
                 .endpoint(endpoint)
                 .omitEmptyPayload(omitEmptyPayload())
-                .allowEmptyStructPayload(httpBinding().hasStructPayload(input.schema()))
-                .requestFactory(requestFactory(context));
+                .allowEmptyStructPayload(httpBinding().hasStructPayload(input.schema()));
 
         if (operation.inputEventBuilderSupplier() != null) {
             serializer.eventEncoderFactory(getEventEncoderFactory(operation));

client/client-core/src/main/java/software/amazon/smithy/java/client/core/ClientPipeline.java

@@ -118,11 +118,6 @@ <I extends SerializableStruct, O extends SerializableStruct> O send(ClientCall<I
         // 4. Interceptors: Invoke ReadBeforeSerialization.
         call.interceptor.readBeforeSerialization(inputHook);
 
-        // 4.a. Let the transport advertise per-call request-construction capabilities (e.g. a
-        //      request factory that serializes headers directly into the transport's native
-        //      representation). No-op for transports that do not opt in.
-        transport.contributeRequestFactory(call.context);
-
         // 5. Serialize the input message into a protocol request message.
         //    Use the UNRESOLVED URI of "/" for now, and resolve the actual endpoint later.
         RequestT request = protocol.createRequest(call.operation, input, call.context, UNRESOLVED);

client/client-core/src/main/java/software/amazon/smithy/java/client/core/ClientTransport.java

@@ -48,19 +48,6 @@ public interface ClientTransport<RequestT, ResponseT> extends Closeable {
      */
     MessageExchange<RequestT, ResponseT> messageExchange();
 
-    /**
-     * Hook invoked once per call, before the protocol serializes the request, letting a transport
-     * advertise per-call request-construction capabilities into the context.
-     *
-     * <p>A transport overrides this to publish a request factory (e.g. one that backs request
-     * headers with the transport's own native container) so the protocol serializes directly into
-     * the transport's representation, avoiding a translation copy at send time. The default is a
-     * no-op, so transports that do not opt in are unaffected.
-     *
-     * @param context the mutable per-call context.
-     */
-    default void contributeRequestFactory(Context context) {}
-
     /**
      * {@inheritDoc}
      *

client/client-http-binding/src/main/java/software/amazon/smithy/java/client/http/binding/HttpBindingClientProtocol.java

@@ -72,8 +72,7 @@ public <I extends SerializableStruct, O extends SerializableStruct> HttpRequest
                 .payloadMediaType(payloadMediaType())
                 .shapeValue(input)
                 .endpoint(endpoint)
-                .omitEmptyPayload(omitEmptyPayload())
-                .requestFactory(requestFactory(context));
+                .omitEmptyPayload(omitEmptyPayload());
 
         if (operation.inputEventBuilderSupplier() != null) {
             serializer.eventEncoderFactory(getEventEncoderFactory(operation));

client/client-http/src/main/java/software/amazon/smithy/java/client/http/HttpClientProtocol.java

@@ -7,10 +7,8 @@
 
 import software.amazon.smithy.java.client.core.ClientProtocol;
 import software.amazon.smithy.java.client.core.MessageExchange;
-import software.amazon.smithy.java.context.Context;
 import software.amazon.smithy.java.endpoints.Endpoint;
 import software.amazon.smithy.java.http.api.HttpRequest;
-import software.amazon.smithy.java.http.api.HttpRequestFactory;
 import software.amazon.smithy.java.http.api.HttpResponse;
 import software.amazon.smithy.model.shapes.ShapeId;
 
@@ -35,21 +33,6 @@ public MessageExchange<HttpRequest, HttpResponse> messageExchange() {
         return HttpMessageExchange.INSTANCE;
     }
 
-    /**
-     * The transport-supplied request factory for this call, if any.
-     *
-     * <p>HTTP protocols use this to serialize a request directly into the transport's native
-     * representation (e.g. headers backed by the transport's own container) instead of a generic one
-     * the transport then copies. Returns null when no transport opted in, in which case the default
-     * array-backed containers are used.
-     *
-     * @param context the per-call context.
-     * @return the transport request factory, or null.
-     */
-    protected static HttpRequestFactory requestFactory(Context context) {
-        return context == null ? null : context.get(HttpContext.TRANSPORT_REQUEST_FACTORY);
-    }
-
     @Override
     public HttpRequest setServiceEndpoint(HttpRequest request, Endpoint endpoint) {
         var merged = request.uri().withEndpoint(endpoint.uri());

client/client-http/src/main/java/software/amazon/smithy/java/client/http/HttpContext.java

@@ -9,7 +9,6 @@
 import software.amazon.smithy.java.context.Context;
 import software.amazon.smithy.java.endpoints.EndpointResolver;
 import software.amazon.smithy.java.http.api.HttpHeaders;
-import software.amazon.smithy.java.http.api.HttpRequestFactory;
 
 /**
  * {@link Context} keys used with HTTP-based clients.
@@ -40,14 +39,5 @@ public final class HttpContext {
     public static final Context.Key<Boolean> DISABLE_REQUEST_COMPRESSION =
             Context.key("If request compression is disabled");
 
-    /**
-     * A transport-supplied factory for the request's mutable containers (headers, and in future the
-     * body), letting an HTTP protocol serialize the request directly into the transport's native
-     * representation. Published by a transport via {@code ClientTransport.contributeRequestFactory}
-     * and read by the protocol's {@code createRequest}. Absent for transports that do not opt in.
-     */
-    public static final Context.Key<HttpRequestFactory> TRANSPORT_REQUEST_FACTORY =
-            Context.key("Transport-supplied HTTP request factory");
-
     private HttpContext() {}
 }

client/client-rpcv2/src/main/java/software/amazon/smithy/java/client/rpcv2/AbstractRpcV2ClientProtocol.java

@@ -108,18 +108,7 @@ public <I extends SerializableStruct, O extends SerializableStruct> HttpRequest
             SmithyUri endpoint
     ) {
         var target = targetPathPrefix + operation.schema().id().getName();
-        // With a transport-supplied factory, build the request directly in the transport's native
-        // representation; otherwise reuse the cached template (unchanged behavior).
-        var factory = requestFactory(context);
-        ModifiableHttpRequest builder;
-        if (factory == null) {
-            builder = templateRequest.toModifiableCopy();
-        } else {
-            builder = HttpRequest.create(factory);
-            builder.setMethod("POST");
-            builder.addHeader(HeaderName.SMITHY_PROTOCOL, smithyProtocolValue);
-            builder.addHeader(HeaderName.ACCEPT, payloadMediaType);
-        }
+        ModifiableHttpRequest builder = templateRequest.toModifiableCopy();
         builder.setUri(endpoint.withConcatPath(target));
 
         if (operation.inputSchema().hasTrait(TraitKey.UNIT_TYPE_TRAIT)) {