Add SPLIT opcode, fix EndpointBddTrait namespace

Author: mtdowling

client/client-rulesengine/src/main/java/software/amazon/smithy/java/client/rulesengine/BytecodeCompiler.java

@@ -32,7 +32,7 @@
 import software.amazon.smithy.rulesengine.language.syntax.rule.Rule;
 import software.amazon.smithy.rulesengine.logic.bdd.Bdd;
 import software.amazon.smithy.rulesengine.logic.bdd.BddNodeConsumer;
-import software.amazon.smithy.rulesengine.logic.bdd.EndpointBddTrait;
+import software.amazon.smithy.rulesengine.traits.EndpointBddTrait;
 
 final class BytecodeCompiler {
 
@@ -304,6 +304,14 @@ public Void visitLibraryFunction(FunctionDefinition fn, List<Expression> args) {
                         writer.writeByte(Opcodes.URI_ENCODE);
                         return null;
                     }
+                    case "split" -> {
+                        // Compile all three arguments (string, delimiter, limit)
+                        compileExpression(args.get(0));
+                        compileExpression(args.get(1));
+                        compileExpression(args.get(2));
+                        writer.writeByte(Opcodes.SPLIT);
+                        return null;
+                    }
                 }
 
                 // A generic function call without a special opcode

client/client-rulesengine/src/main/java/software/amazon/smithy/java/client/rulesengine/BytecodeDisassembler.java

@@ -80,6 +80,7 @@ final class BytecodeDisassembler {
             Map.entry(Opcodes.IS_VALID_HOST_LABEL, new InstructionDef("IS_VALID_HOST_LABEL", OperandType.NONE)),
             Map.entry(Opcodes.PARSE_URL, new InstructionDef("PARSE_URL", OperandType.NONE)),
             Map.entry(Opcodes.URI_ENCODE, new InstructionDef("URI_ENCODE", OperandType.NONE)),
+            Map.entry(Opcodes.SPLIT, new InstructionDef("SPLIT", OperandType.NONE)),
 
             // Return operations
             Map.entry(Opcodes.RETURN_ERROR, new InstructionDef("RETURN_ERROR", OperandType.NONE)),

client/client-rulesengine/src/main/java/software/amazon/smithy/java/client/rulesengine/BytecodeEvaluator.java

@@ -18,6 +18,7 @@
 import software.amazon.smithy.java.io.uri.URLEncoding;
 import software.amazon.smithy.rulesengine.language.syntax.expressions.functions.IsValidHostLabel;
 import software.amazon.smithy.rulesengine.language.syntax.expressions.functions.ParseUrl;
+import software.amazon.smithy.rulesengine.language.syntax.expressions.functions.Split;
 import software.amazon.smithy.rulesengine.language.syntax.expressions.functions.Substring;
 import software.amazon.smithy.rulesengine.logic.ConditionEvaluator;
 
@@ -381,6 +382,15 @@ private Object run(int start) {
                         stackPosition--; // Pop the null value
                     }
                 }
+                case Opcodes.SPLIT -> {
+                    // Pops 3, pushes 1
+                    int idx = stackPosition - 3;
+                    var string = (String) stack[idx];
+                    var delimiter = (String) stack[idx + 1];
+                    var limit = ((Number) stack[idx + 2]).intValue();
+                    stack[idx] = Split.split(string, delimiter, limit);
+                    stackPosition = idx + 1;
+                }
                 default -> throw new RulesEvaluationError("Unknown rules engine instruction: " + opcode, pc);
             }
         }

client/client-rulesengine/src/main/java/software/amazon/smithy/java/client/rulesengine/EndpointRulesPlugin.java

@@ -14,8 +14,8 @@
 import software.amazon.smithy.java.context.Context;
 import software.amazon.smithy.java.core.schema.TraitKey;
 import software.amazon.smithy.java.logging.InternalLogger;
-import software.amazon.smithy.rulesengine.logic.bdd.EndpointBddTrait;
 import software.amazon.smithy.rulesengine.traits.ContextParamTrait;
+import software.amazon.smithy.rulesengine.traits.EndpointBddTrait;
 import software.amazon.smithy.rulesengine.traits.EndpointRuleSetTrait;
 import software.amazon.smithy.rulesengine.traits.OperationContextParamsTrait;
 import software.amazon.smithy.rulesengine.traits.StaticContextParamsTrait;

client/client-rulesengine/src/main/java/software/amazon/smithy/java/client/rulesengine/Opcodes.java

@@ -413,4 +413,13 @@ private Opcodes() {}
      * <p><code>JNN_OR_POP [offset:ushort]</code>
      */
     public static final byte JNN_OR_POP = 42;
+
+    /**
+     * Pop a string, delimiter, and limit from the stack and push the split result.
+     *
+     * <p>Stack: [..., string, delimiter, limit] => [..., list]
+     *
+     * <p><code>SPLIT</code>
+     */
+    public static final byte SPLIT = 41;
 }

client/client-rulesengine/src/main/java/software/amazon/smithy/java/client/rulesengine/RulesEngineBuilder.java

@@ -17,7 +17,7 @@
 import java.util.ServiceLoader;
 import java.util.function.Function;
 import software.amazon.smithy.java.context.Context;
-import software.amazon.smithy.rulesengine.logic.bdd.EndpointBddTrait;
+import software.amazon.smithy.rulesengine.traits.EndpointBddTrait;
 
 /**
  * Compiles and loads a rules engine used to resolve endpoints based on Smithy's rules engine traits.

client/client-rulesengine/src/test/java/software/amazon/smithy/java/client/rulesengine/BytecodeCompilerTest.java

@@ -41,7 +41,7 @@
 import software.amazon.smithy.rulesengine.language.syntax.rule.NoMatchRule;
 import software.amazon.smithy.rulesengine.language.syntax.rule.Rule;
 import software.amazon.smithy.rulesengine.logic.bdd.Bdd;
-import software.amazon.smithy.rulesengine.logic.bdd.EndpointBddTrait;
+import software.amazon.smithy.rulesengine.traits.EndpointBddTrait;
 
 class BytecodeCompilerTest {
 

client/client-rulesengine/src/test/java/software/amazon/smithy/java/client/rulesengine/BytecodeEvaluatorTest.java

@@ -744,6 +744,30 @@ void testUriEncode() {
         evaluator.test(0);
     }
 
+    @Test
+    void testSplitWithLimit() {
+        writer.markConditionStart();
+        writer.writeByte(Opcodes.LOAD_CONST);
+        writer.writeByte(writer.getConstantIndex("a--b--c--d"));
+        writer.writeByte(Opcodes.LOAD_CONST);
+        writer.writeByte(writer.getConstantIndex("--"));
+        writer.writeByte(Opcodes.LOAD_CONST);
+        writer.writeByte(writer.getConstantIndex(2));
+        writer.writeByte(Opcodes.SPLIT);
+        // Get the second element (should be "b--c--d")
+        writer.writeByte(Opcodes.GET_INDEX);
+        writer.writeByte(1);
+        writer.writeByte(Opcodes.LOAD_CONST);
+        writer.writeByte(writer.getConstantIndex("b--c--d"));
+        writer.writeByte(Opcodes.STRING_EQUALS);
+        writer.writeByte(Opcodes.RETURN_VALUE);
+
+        bytecode = buildBytecode();
+        evaluator = createEvaluator(bytecode);
+
+        assertTrue(evaluator.test(0));
+    }
+
     private BytecodeEvaluator createEvaluator(Bytecode bytecode) {
         RegisterFiller filler = RegisterFiller.of(bytecode, Collections.emptyMap());
         BytecodeEvaluator eval = new BytecodeEvaluator(bytecode, new RulesExtension[0], filler);

client/client-rulesengine/src/test/java/software/amazon/smithy/java/client/rulesengine/EndpointRulesPluginTest.java

@@ -25,8 +25,8 @@
 import software.amazon.smithy.model.shapes.ShapeId;
 import software.amazon.smithy.model.traits.Trait;
 import software.amazon.smithy.rulesengine.language.EndpointRuleSet;
-import software.amazon.smithy.rulesengine.logic.bdd.EndpointBddTrait;
 import software.amazon.smithy.rulesengine.logic.cfg.Cfg;
+import software.amazon.smithy.rulesengine.traits.EndpointBddTrait;
 import software.amazon.smithy.utils.IoUtils;
 
 public class EndpointRulesPluginTest {