Client call decorator#1211
Closed
mtdowling wants to merge 6 commits into
Closed
Conversation
Fixes #1197 Co-Authored-By: Michael Dowling <michael@mtdowling.com>
…s in call decorators
…ow access in call decorators" This reverts commit 72dc964.
CallDecorator can compose in onion order via CallDecorator.chain, and plugins register them additively with addCallDecorator so multiple plugins can layer behavior without clobbering each other. Decorators receive a ClientCallView, a read-only handle to the resolved call (input, operation, merged context, endpoint resolver, type registry, auth scheme resolver and schemes, identity resolvers). The view is implemented by the existing package-private ClientCall, so no extra allocation per call. Override merging and modifyBeforeCall now happen up-front in buildCall, so RequestOverrideConfig stops leaking into the public decorator surface and decorators see the same effective context as interceptors.
timocov
approved these changes
May 25, 2026
etimokhov-wise
approved these changes
May 25, 2026
timocov
approved these changes
May 25, 2026
adwsingh
approved these changes
May 26, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1197
In contrast to interceptors, call decorators allow modifying control flow. Decorators can short-circuit calls, do request hedging, caching, be re-entrant, etc. Decorators run after modifyBeforeCall so they see the fully resolved configuration, and modifyBeforeCall can install or replace the decorator per request.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.