Allow .api.aws endpoints#758
Merged
Merged
Conversation
adwsingh
reviewed
Jun 9, 2025
| import java.util.Set; | ||
|
|
||
| final class ApiStandardTerminology { | ||
| public final class ApiStandardTerminology { |
rhernandez35
reviewed
Jun 9, 2025
Comment on lines
+43
to
+44
| public static final Set<String> READ_ONLY_API_PREFIXES = withCommonsPrefixes(READ_ONLY_TERMS); | ||
| public static final Set<String> WRITE_API_PREFIXES = withCommonsPrefixes(WRITE_TERMS); |
Collaborator
There was a problem hiding this comment.
Expose these through static getters if they need to be exposed. Direct field access limits our ability to change how these lists are constructed in the future.
adwsingh
reviewed
Jun 9, 2025
Comment on lines
+43
to
+49
| public static Set<String> getReadOnlyApiPrefixes() { | ||
| return withCommonsPrefixes(READ_ONLY_TERMS); | ||
| } | ||
|
|
||
| public static Set<String> getWriteApiPrefixes() { | ||
| return withCommonsPrefixes(WRITE_TERMS); | ||
| } |
Contributor
There was a problem hiding this comment.
We don't need to keep computing these every time.Just store those in the constants, make them private but expose them via the getters.
rhernandez35
approved these changes
Jun 9, 2025
chenliu0831
enabled auto-merge (squash)
June 10, 2025 16:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Datazone endpoints end in .api.aws instead of
.amazonaws.com.ApiStandardTerminology made public for testing and convenience.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.