Skip to content

Allow .api.aws endpoints #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenliu0831 merged 8 commits into from
Jun 10, 2025
Merged

Allow .api.aws endpoints #758

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f1a9511
Allow .api.aws endpoints
Jun 4, 2025
0a62270
Change common api prefixes to function calls
Jun 9, 2025
bc0da51
Address comments
Jun 9, 2025
11bc4e3
Merge branch 'main' into allow-api-aws-endpoints
shwdean Jun 10, 2025
7fd281f
Run spotless
rhernandez35 Jun 10, 2025
f62a567
Merge branch 'main' into allow-api-aws-endpoints
shwdean Jun 10, 2025
3f36247
Fix spotbugs and remove public visibility
Jun 10, 2025
84c24a3
Fix spotless
Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions ...in/java/software/amazon/smithy/java/aws/servicebundle/bundler/ApiStandardTerminology.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import java.util.HashSet;
import java.util.Set;

final class ApiStandardTerminology {
public final class ApiStandardTerminology {

@adwsingh adwsingh Jun 9, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why public?


private static final Set<String> COMMON_PREFIXES = Set.of("Batch");
private static final Set<String> READ_ONLY_TERMS =
Expand Down Expand Up @@ -40,8 +40,16 @@ final class ApiStandardTerminology {
"Untag",
"Update");

static final Set<String> READ_ONLY_API_PREFIXES = withCommonsPrefixes(READ_ONLY_TERMS);
static final Set<String> WRITE_API_PREFIXES = withCommonsPrefixes(WRITE_TERMS);
private static final Set<String> READ_ONLY_API_PREFIXES = withCommonsPrefixes(READ_ONLY_TERMS);
private static final Set<String> WRITE_API_PREFIXES = withCommonsPrefixes(WRITE_TERMS);

public static Set<String> getReadOnlyApiPrefixes() {
return READ_ONLY_API_PREFIXES;
}

public static Set<String> getWriteApiPrefixes() {
return WRITE_API_PREFIXES;
}
Comment on lines +43 to +55

@adwsingh adwsingh Jun 9, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to keep computing these every time.Just store those in the constants, make them private but expose them via the getters.


private ApiStandardTerminology() {}

Expand Down
11 changes: 7 additions & 4 deletions ...rc/main/java/software/amazon/smithy/java/aws/servicebundle/bundler/AwsServiceBundler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,8 @@ public Builder blockedOperations(Set<String> blockedOperations) {
}

public Builder readOnlyOperations() {
this.allowedPrefixes(ApiStandardTerminology.READ_ONLY_API_PREFIXES);
this.blockedPrefixes(ApiStandardTerminology.WRITE_API_PREFIXES);
this.allowedPrefixes(ApiStandardTerminology.getReadOnlyApiPrefixes());
this.blockedPrefixes(ApiStandardTerminology.getWriteApiPrefixes());
return this;
}

Expand Down Expand Up @@ -239,8 +239,11 @@ Map<String, String> parseEndpoints(ObjectNode endpointTests) {
continue;
}

if (endpoint.startsWith("https://") && endpoint.endsWith(region + ".amazonaws.com")) {
if (endpoint.endsWith(region + ".amazonaws.com") || endpoint.contains(region + ".amazonaws.com.")) {
if (endpoint.startsWith("https://")) {
if (endpoint.endsWith(region + ".amazonaws.com")
|| endpoint.contains(region + ".amazonaws.com.")
|| endpoint.endsWith(region + ".api.aws")
) {
var prev = endpoints.put(region, endpoint);
if (prev != null && !endpoint.equals(prev)) {
throw new RuntimeException(
Expand Down
4 changes: 2 additions & 2 deletions ...est/java/software/amazon/smithy/java/aws/servicebundle/bundler/AwsServiceBundlerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ public void testReadAndWritePrefixes() {
var bundler = AwsServiceBundler.builder()
.serviceName("dynamodb")
.resolver(serviceName -> getModel("dynamodb-2012-08-10.json"))
.allowedPrefixes(ApiStandardTerminology.READ_ONLY_API_PREFIXES)
.blockedPrefixes(ApiStandardTerminology.WRITE_API_PREFIXES)
.allowedPrefixes(ApiStandardTerminology.getReadOnlyApiPrefixes())
.blockedPrefixes(ApiStandardTerminology.getWriteApiPrefixes())
.build();
var bundle = bundler.bundle();
var bundleModel = new ModelAssembler().addUnparsedModel("model.json", bundle.getModel())
Expand Down
Loading