Default to only launching Smithy bundles when no bundles are specified#762
Merged
Conversation
rhernandez35
enabled auto-merge (rebase)
June 10, 2025 17:29
adwsingh
reviewed
Jun 10, 2025
Comment on lines
+81
to
+91
| toolBundles = new ArrayList<>(config.getToolBundles() | ||
| .entrySet() | ||
| .stream() | ||
| .filter(entry -> { | ||
| // By default, only include smithy bundles if no bundles are specified. | ||
| // We can undo this once we have fanout support for generic bundles. | ||
| var bundle = entry.getValue(); | ||
| return bundle.getValue() instanceof McpBundleConfig.SmithyModeledMember; | ||
| }) | ||
| .map(Map.Entry::getKey) | ||
| .toList()); |
Contributor
There was a problem hiding this comment.
Suggested change
| toolBundles = new ArrayList<>(config.getToolBundles() | |
| .entrySet() | |
| .stream() | |
| .filter(entry -> { | |
| // By default, only include smithy bundles if no bundles are specified. | |
| // We can undo this once we have fanout support for generic bundles. | |
| var bundle = entry.getValue(); | |
| return bundle.getValue() instanceof McpBundleConfig.SmithyModeledMember; | |
| }) | |
| .map(Map.Entry::getKey) | |
| .toList()); | |
| toolBundles = config.getToolBundles() | |
| .entrySet() | |
| .stream() | |
| .filter(entry -> { | |
| // By default, only include smithy bundles if no bundles are specified. | |
| // We can undo this once we have fanout support for generic bundles. | |
| var bundle = entry.getValue(); | |
| return bundle.getValue() instanceof McpBundleConfig.SmithyModeledMember; | |
| }) | |
| .map(Map.Entry::getKey) | |
| .toList(); |
adwsingh
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.