Skip to content

Update client configs in configure command #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhernandez35 merged 1 commit into from
Jun 11, 2025
Merged

Update client configs in configure command #769

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions mcp/mcp-cli-api/src/main/java/software/amazon/smithy/java/mcp/cli/AbstractAddBundle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@

package software.amazon.smithy.java.mcp.cli;

import java.util.List;
import java.util.Set;
import picocli.CommandLine;
import software.amazon.smithy.java.mcp.cli.model.Location;
import software.amazon.smithy.java.mcp.cli.model.McpServerConfig;

/**
* Abstract base class for CLI commands that add tool bundles to the Smithy MCP configuration.
Expand All @@ -16,6 +20,10 @@
*/
public abstract class AbstractAddBundle extends SmithyMcpCommand implements ConfigurationCommand {

@CommandLine.Option(names = {"--clients"},
description = "Names of client configs to update. If not specified all client configs registered would be updated")
protected Set<String> clients = Set.of();

@Override
public final void execute(ExecutionContext context) throws Exception {
var config = context.config();
Expand All @@ -25,6 +33,11 @@ public final void execute(ExecutionContext context) throws Exception {
}
var newConfig = getNewToolConfig();
ConfigUtils.addMcpBundle(config, getToolBundleName(), newConfig.mcpBundle());
var command = McpServerConfig.builder()
.command("mcp-registry")
.args(List.of("start-server", getToolBundleName()))
.build();
ConfigUtils.addToClientConfigs(config, getToolBundleName(), clients, command);
System.out.println("Added tool bundle " + getToolBundleName());
}

Expand Down