Allow read only operations by default#772
Merged
Merged
Conversation
rhernandez35
approved these changes
Jun 11, 2025
adwsingh
reviewed
Jun 11, 2025
Comment on lines
+40
to
+49
| protected boolean readOnlyApis; | ||
|
|
||
| @Override | ||
| protected CliBundle getNewToolConfig() { | ||
| var bundleBuilder = AwsServiceBundler.builder() | ||
| .serviceName(awsServiceName); | ||
| //If nothing is specified then default to only readOnlyOperations. | ||
| if (readOnlyApis) { | ||
| // Include read-only apis unless disabled | ||
| bundleBuilder.readOnlyOperations(); | ||
| } |
Contributor
There was a problem hiding this comment.
I think this should be Boolean and we should still only respect the allowedApis if explicitly passed. Right now there is no way for a customer to only create a bundle for a single API without blockingListing every other one.
IMO what would be better is this,
- If nothing is passed default to read-only-apis.
- If an allow list is passed use only that. Users can optionally also pass read-only-apis and then they get the union of allowList and readOnlyApis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows users to incrementally allow write APIs without re-specifying the entire list of read-only APIs
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.