Skip to content

Support multiple bundles in install command #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhernandez35 merged 2 commits into from
Jun 12, 2025
Merged

Support multiple bundles in install command #773

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8b850f
Support multiple bundles in install command
rhernandez35 Jun 11, 2025
1766f3c
Merge branch 'main' into install-lots-of-servers
rhernandez35 Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 37 additions & 35 deletions mcp/mcp-cli/src/main/java/software/amazon/smithy/java/mcp/cli/commands/InstallBundle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ public class InstallBundle extends SmithyMcpCommand {
description = "Name of the registry to list the bundles from. If not provided it will use the default registry.")
String registryName;

@Parameters(description = "Name of the MCP bundle to install.")
String name;
@Parameters(description = "Names of the MCP bundles to install.")
Set<String> names;

@Option(names = {"--clients"},
description = "Names of client configs to update. If not specified all client configs registered would be updated")
Expand All @@ -41,39 +41,41 @@ public class InstallBundle extends SmithyMcpCommand {
protected void execute(ExecutionContext context) throws IOException {
var registry = context.registry();
var config = context.config();
var bundle = registry.getMcpBundle(name);
ConfigUtils.addMcpBundle(config, name, bundle);

var command = name;
List<String> args = null;
boolean shouldCreateWrapper = true;

if (bundle.getValue() instanceof GenericBundle genericBundle && genericBundle.isExecuteDirectly()) {
command = genericBundle.getRun().getExecutable();
args = genericBundle.getRun().getArgs();
shouldCreateWrapper = false;
}

if (shouldCreateWrapper) {
ConfigUtils.createWrapperScript(name);
ConfigUtils.ensureMcpServersDirInPath();
}

var newClientConfig = McpServerConfig.builder()
.command(command)
.args(args)
.build();
if (print == null) {
//By default, print the output if there are no configured client configs.
print = !config.hasClientConfigs();
}
ConfigUtils.addToClientConfigs(config, name, clients, newClientConfig);

System.out.println("Successfully installed " + name);

if (print) {
System.out.println("You can add the following to your MCP Servers config to use " + name);
System.out.println(newClientConfig);
for (var name : names) {
var bundle = registry.getMcpBundle(name);
ConfigUtils.addMcpBundle(config, name, bundle);

var command = name;
List<String> args = null;
boolean shouldCreateWrapper = true;

if (bundle.getValue() instanceof GenericBundle genericBundle && genericBundle.isExecuteDirectly()) {
command = genericBundle.getRun().getExecutable();
args = genericBundle.getRun().getArgs();
shouldCreateWrapper = false;
}

if (shouldCreateWrapper) {
ConfigUtils.createWrapperScript(name);
ConfigUtils.ensureMcpServersDirInPath();
}

var newClientConfig = McpServerConfig.builder()
.command(command)
.args(args)
.build();
if (print == null) {
//By default, print the output if there are no configured client configs.
print = !config.hasClientConfigs();
}
ConfigUtils.addToClientConfigs(config, name, clients, newClientConfig);

System.out.println("Successfully installed " + name);

if (print) {
System.out.println("You can add the following to your MCP Servers config to use " + name);
System.out.println(newClientConfig);
}
}
}

Expand Down