Skip to content

If allowedApis is provided respect that always #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhernandez35 merged 1 commit into from
Jun 14, 2025
Merged

If allowedApis is provided respect that always #774

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions ...s/src/main/java/software/amazon/smithy/java/aws/mcp/cli/commands/AddAwsServiceBundle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,22 +35,28 @@ public class AddAwsServiceBundle extends AbstractAddBundle {
protected Set<String> blockedApis;

@Option(names = "--read-only-apis",
description = "Include read only APIs in the MCP server",
defaultValue = "true")
protected boolean readOnlyApis;
description = "Include read only APIs in the MCP server")
protected Boolean readOnlyApis;

@Override
protected CliBundle getNewToolConfig() {
var bundleBuilder = AwsServiceBundler.builder()
.serviceName(awsServiceName);
if (readOnlyApis) {
// Include read-only apis unless disabled
bundleBuilder.readOnlyOperations();
}
if (allowedApis != null) {
// User explicitly specified allowed APIs - use only those
// User explicitly specified allowed APIs
bundleBuilder.exposedOperations(allowedApis);
// If readOnlyApis is also requested, include those as well
if (Boolean.TRUE.equals(readOnlyApis)) {
bundleBuilder.readOnlyOperations();
}
} else if (!Boolean.FALSE.equals(readOnlyApis)) {
//If nothing is specified then default to only readOnlyOperations.
bundleBuilder.readOnlyOperations();
} else {
throw new IllegalArgumentException("You have turned off readOnlyApis and also not specified any " +
"allowedApis so there are no operations to create a bundle for.");
}

if (blockedApis != null) {
// Always apply blocked operations if specified
bundleBuilder.blockedOperations(blockedApis);
Expand Down