Add client-config command to configure client config#776
Merged
Conversation
adwsingh
force-pushed
the
adwsingh/client-config-command
branch
from
June 12, 2025 21:27
22fd923 to
afe15fe
Compare
adwsingh
force-pushed
the
adwsingh/client-config-command
branch
from
June 12, 2025 21:30
afe15fe to
3888616
Compare
adwsingh
force-pushed
the
adwsingh/client-config-command
branch
from
June 12, 2025 21:45
3888616 to
2f380a6
Compare
rhernandez35
approved these changes
Jun 12, 2025
| @Command(name = "add", description = "Add a new MCP client configuration") | ||
| public static final class AddCommand extends SmithyMcpCommand implements ConfigurationCommand { | ||
|
|
||
| @Parameters(index = "0", description = "Client name (e.g., 'q-cli')") |
Collaborator
There was a problem hiding this comment.
should just be q to match the command nameshould just be q to match the command name
Contributor
Author
There was a problem hiding this comment.
Ehh, we have used q-cli for Q, so I didn't want to confuse users.
| String filePath; | ||
|
|
||
| @Option(names = {"--overwrite"}, description = "Overwrite existing client configuration if it exists", | ||
| defaultValue = "false") |
Collaborator
There was a problem hiding this comment.
Why false? I'd think invoking this command would indicate my desire to overwrite the existing config.
Contributor
Author
There was a problem hiding this comment.
We follow the same convention everywhere, by default don't overwrite and just warn.
rhernandez35
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.