Skip to content

Allow newlines in single quotes when parsing string nodes#259

Open
a-morales wants to merge 1 commit into
smithy-lang:mainfrom
a-morales:fix-str-node-parsing
Open

Allow newlines in single quotes when parsing string nodes#259
a-morales wants to merge 1 commit into
smithy-lang:mainfrom
a-morales:fix-str-node-parsing

Conversation

@a-morales

Copy link
Copy Markdown

Description of changes:

Given the valid smithy definition below

@documentation(
"A multiline
documentation
string using
single quotes"
)
structure Foo {}

The LSP parsing code for string nodes was only parsing to the end of the first line. This resulted in subsequent Nodes being incorrect and would result in a NPE here

The Smithy IDL grammar does allow for single quoted strings to contain new lines

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@a-morales a-morales requested a review from a team as a code owner June 30, 2026 19:53
@a-morales a-morales requested a review from joewyz June 30, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant