Allow newlines in single quotes when parsing string nodes#259
Open
a-morales wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Given the valid smithy definition below
The LSP parsing code for string nodes was only parsing to the end of the first line. This resulted in subsequent Nodes being incorrect and would result in a NPE here
smithy-language-server/src/main/java/software/amazon/smithy/lsp/language/DocumentSymbolHandler.java
Line 49 in 8dc6c7b
The Smithy IDL grammar does allow for single quoted strings to contain new lines
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.