Skip to content

fix(smithy-aws-core): omit Result wrapper for empty awsQuery output #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alan4506 merged 3 commits into from
Jun 10, 2026
+11 −3
Merged

fix(smithy-aws-core): omit Result wrapper for empty awsQuery output #714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
328aae2
fix(smithy-aws-core): omit Result wrapper for empty awsQuery output
Alan4506 Jun 8, 2026
06cb461
Add changelog entry
Alan4506 Jun 8, 2026
9adab01
Remove unit test of the fix
Alan4506 Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...s-core/.changes/next-release/smithy-aws-core-bugfix-05435b3fb9a54b86b4ebb4d61b0d13ae.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"type": "bugfix",
"description": "Fixed awsQuery response deserialization for operations with no output members."
}
10 changes: 7 additions & 3 deletions packages/smithy-aws-core/src/smithy_aws_core/aio/protocols.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,10 +364,14 @@ def _action_name(
def _response_wrapper_elements(
self,
operation: APIOperation[SerializeableShape, DeserializeableShape],
) -> tuple[str, str]:
) -> tuple[str, ...]:
name = operation.schema.id.name
# Operations with no output members will omit the <OpResult> element.
if not operation.output_schema.members:
return (f"{name}Response",)
return (
f"{operation.schema.id.name}Response",
f"{operation.schema.id.name}Result",
f"{name}Response",
f"{name}Result",
)

def _error_wrapper_elements(self) -> tuple[str, ...]:
Expand Down
Loading