fix: Convert log_info dict to string for logging#35
Open
phmoferring wants to merge 1 commit intosnakemake:mainfrom
Open
fix: Convert log_info dict to string for logging#35phmoferring wants to merge 1 commit intosnakemake:mainfrom
log_info dict to string for logging#35phmoferring wants to merge 1 commit intosnakemake:mainfrom
Conversation
Contributor
📝 WalkthroughWalkthroughAdjusted a debug log in snakemake_executor_plugin_aws_batch/init.py to log the stringified dictionary for job status instead of the dictionary object. No control flow, return values, or public interfaces were changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
log_info dict to string for logginglog_info dict to string for logging
log_info dict to string for logginglog_info dict to string for logging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a recent release of snakemake, passing a dict to the logger spits out an error like the following:
This change resolves to the previous functionality of just printing the dict as a string:
I haven't dug into what specific change in
snakemakecaused the deviation in handling, but I suspect it was in release v9.11.1, which lists "logging refinements" in its changelog. It doesn't actually affect workflow execution, but it pollutes the log with these error messages.Summary by CodeRabbit