Skip to content

Commit c5f3459

Browse files
authored
fix: defunct release-please action (#46)
* fix: release please action * fix: add required dir in examples + formatting * fix: bring back major minor tagging
1 parent 22d9209 commit c5f3459

3 files changed

Lines changed: 29 additions & 25 deletions

File tree

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: PR
1+
name: Lint PR
22
on:
33
pull_request_target:
44
types:
@@ -8,9 +8,12 @@ on:
88
- synchronize
99

1010
jobs:
11-
title-format:
11+
main:
12+
name: Validate PR title
1213
runs-on: ubuntu-latest
14+
permissions:
15+
pull-requests: read
1316
steps:
14-
- uses: amannn/action-semantic-pull-request@v3.4.0
17+
- uses: amannn/action-semantic-pull-request@v6
1518
env:
16-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
19+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/release-please.yml

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,33 +3,34 @@ on:
33
branches:
44
- master
55

6+
permissions:
7+
contents: write
8+
pull-requests: write
9+
issues: write
10+
611
name: release-please
712

813
jobs:
914
release-please:
1015
runs-on: ubuntu-latest
1116
steps:
12-
13-
- uses: GoogleCloudPlatform/release-please-action@v2
17+
- uses: googleapis/release-please-action@v4
1418
id: release
1519
with:
16-
release-type: go # just no update of version anywhere needed
17-
package-name: ${{env.ACTION_NAME}}
18-
19-
- uses: actions/checkout@v2
20-
if: ${{ steps.release.outputs.release_created }}
21-
20+
token: ${{ secrets.GITHUB_TOKEN }}
21+
release-type: go # just keep a changelog, no version anywhere outside of git tags
22+
- uses: actions/checkout@v4
2223
- name: tag major and minor versions
2324
if: ${{ steps.release.outputs.release_created }}
2425
run: |
2526
git config user.name github-actions[bot]
2627
git config user.email 41898282+github-actions[bot]@users.noreply.github.com
27-
git remote add gh-token "https://${{ secrets.GITHUB_TOKEN }}@github.com/google-github-actions/release-please-action.git"
28+
git remote add gh-token "https://${{ secrets.GITHUB_TOKEN }}@github.com/googleapis/release-please-action.git"
2829
git tag -d v${{ steps.release.outputs.major }} || true
2930
git tag -d v${{ steps.release.outputs.major }}.${{ steps.release.outputs.minor }} || true
3031
git push origin :v${{ steps.release.outputs.major }} || true
3132
git push origin :v${{ steps.release.outputs.major }}.${{ steps.release.outputs.minor }} || true
3233
git tag -a v${{ steps.release.outputs.major }} -m "Release v${{ steps.release.outputs.major }}"
3334
git tag -a v${{ steps.release.outputs.major }}.${{ steps.release.outputs.minor }} -m "Release v${{ steps.release.outputs.major }}.${{ steps.release.outputs.minor }}"
3435
git push origin v${{ steps.release.outputs.major }}
35-
git push origin v${{ steps.release.outputs.major }}.${{ steps.release.outputs.minor }}
36+
git push origin v${{ steps.release.outputs.major }}.${{ steps.release.outputs.minor }}

README.md

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -32,25 +32,25 @@ Whether used disk space shall be printed if Snakemake fails. Can be either `true
3232

3333
```yaml
3434
- name: Linting
35-
uses: snakemake/snakemake-github-action@v1
35+
uses: snakemake/snakemake-github-action@v2
3636
with:
37-
directory: '.test'
38-
snakefile: 'workflow/Snakefile'
39-
args: '--lint'
37+
directory: ".test"
38+
snakefile: "workflow/Snakefile"
39+
args: "--lint"
4040

4141
- name: Testing
4242
uses: snakemake/snakemake-github-action@v2
4343
with:
44-
directory: '.test'
45-
snakefile: 'workflow/Snakefile'
46-
args: '--cores 1 --sdm conda --conda-cleanup-pkgs cache'
47-
stagein: '' # additional preliminary commands to run (can be multiline)
44+
directory: ".test"
45+
snakefile: "workflow/Snakefile"
46+
args: "--cores 1 --sdm conda --conda-cleanup-pkgs cache"
47+
stagein: "" # additional preliminary commands to run (can be multiline)
4848
show-disk-usage-on-error: true
4949

50-
5150
- name: Create container file
5251
uses: snakemake/snakemake-github-action@v2
5352
with:
54-
snakefile: 'workflow/Snakefile'
55-
task: 'containerize'
53+
directory: ".test"
54+
snakefile: "workflow/Snakefile"
55+
task: "containerize"
5656
```

0 commit comments

Comments
 (0)