fix: break circular import

johanneskoester · johanneskoester · commit aed33aa2aba2 · 2023-12-19T21:35:59.000+01:00
diff --git a/snakemake_interface_executor_plugins/registry/__init__.py b/snakemake_interface_executor_plugins/registry/__init__.py
@@ -10,7 +10,6 @@
     ExecutorSettingsBase,
 )
 
-from snakemake_interface_executor_plugins.executors.base import AbstractExecutor
 from snakemake_interface_common.plugin_registry.attribute_types import (
     AttributeKind,
     AttributeMode,
@@ -38,6 +37,8 @@ def load_plugin(self, name: str, module: types.ModuleType) -> Plugin:
         )
 
     def expected_attributes(self) -> Mapping[str, AttributeType]:
+        # break otherwise circular import
+        from snakemake_interface_executor_plugins.executors.base import AbstractExecutor
         return {
             "common_settings": AttributeType(
                 cls=CommonSettings,

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,6 @@`
`10`	`10`	`ExecutorSettingsBase,`
`11`	`11`	`)`
`12`	`12`
`13`		`-from snakemake_interface_executor_plugins.executors.base import AbstractExecutor`
`14`	`13`	`from snakemake_interface_common.plugin_registry.attribute_types import (`
`15`	`14`	`AttributeKind,`
`16`	`15`	`AttributeMode,`
`@@ -38,6 +37,8 @@ def load_plugin(self, name: str, module: types.ModuleType) -> Plugin:`
`38`	`37`	`)`
`39`	`38`
`40`	`39`	`def expected_attributes(self) -> Mapping[str, AttributeType]:`
	`40`	`+ # break otherwise circular import`
	`41`	`+ from snakemake_interface_executor_plugins.executors.base import AbstractExecutor`
`41`	`42`	`return {`
`42`	`43`	`"common_settings": AttributeType(`
`43`	`44`	`cls=CommonSettings,`