Skip to content

fix: properly check source file type in test suite #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johanneskoester merged 1 commit into from
Sep 12, 2025
Merged

fix: properly check source file type in test suite #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion snakemake_interface_software_deployment_plugins/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,10 +129,15 @@ def test_identity_attributes(self):

def test_source_path_attributes(self):
spec = self.get_env_spec()

def is_source_file_or_none(attr: str) -> bool:
val = getattr(spec, attr)
return val is None or isinstance(val, EnvSpecSourceFile)

assert all(
isinstance(attr, str)
and hasattr(spec, attr)
and isinstance(getattr(spec, attr), (EnvSpecSourceFile, None))
and is_source_file_or_none(attr)
for attr in spec.source_path_attributes()
), "bug in plugin: all source path attributes must be of type EnvSpecSourceFile"

Expand Down