factor out repo cleanup

Author: btraven00

source/_templates/plugin_base.rst.j2

@@ -12,13 +12,11 @@ Snakemake {% block type %}{% endblock %} plugin: {{ plugin_name }}
    :target: #
 {% endif -%}
 {% if repository_type == "github" and repository is not none -%}
-{% set repo = repository.replace("https://github.com/", "").replace(".git", "").rstrip("/") -%}
-.. image:: https://img.shields.io/github/last-commit/{{ repo }}
+.. image:: https://img.shields.io/github/last-commit/{{ repository_cleaned }}
    :alt: GitHub - Last commit
    :target: {{ repository }}
 {% elif repository_type == "gitlab" and repository is not none -%}
-{% set repo = repository.replace("https://gitlab.com/", "").replace(".git", "").rstrip("/") -%}
-.. image:: https://img.shields.io/gitlab/last-commit/{{ repo }}
+.. image:: https://img.shields.io/gitlab/last-commit/{{ repository_cleaned }}
    :alt: GitLab - Last commit
    :target: {{ repository }}
 {% elif commit_info is not none -%}

source/collect_plugins.py

@@ -310,11 +310,17 @@ def get_setting_meta(setting, key, default="", verb=False):
                 else:
                     error += "\n\nPlease contact the plugin authors."
 
+            # Clean up repository URL for shields.io badges
+            repository_cleaned = (
+                _cleanup_repository_url(repository) if repository else None
+            )
+
             rendered = templates.get_template(f"{plugin_type}_plugin.rst.j2").render(
                 plugin_name=plugin_name,
                 package_name=package,
                 authors=authors,
                 repository=repository,
+                repository_cleaned=repository_cleaned,
                 repository_type=repository_type,
                 commit_info=commit_info,
                 commit_url=commit_url,
@@ -400,6 +406,38 @@ def _commit_url(
         return repository
 
 
+def _cleanup_repository_url(repository: Optional[str]) -> str:
+    """Clean up repository URL for shields.io badges.
+
+    Removes protocol and known forge prefix (https://github.com/ or https://gitlab.com/),
+    removes .git suffix, and strips trailing slashes.
+
+    Args:
+        repository: Full repository URL (e.g., https://github.com/user/repo.git)
+
+    Returns:
+        Cleaned repository path (e.g., user/repo)
+    """
+    if not repository:
+        return ""
+
+    # Remove protocol and domain prefixes
+    cleaned = (
+        repository.replace("https://github.com/", "")
+        .replace("https://gitlab.com/", "")
+        .replace("http://github.com/", "")
+        .replace("http://gitlab.com/", "")
+    )
+
+    # Remove .git suffix
+    cleaned = cleaned.replace(".git", "")
+
+    # Strip trailing slashes
+    cleaned = cleaned.rstrip("/")
+
+    return cleaned
+
+
 def _commit_age_color(date_str: str) -> str:
     """Return a shields.io color hex based on how old the commit date is."""
     dt = datetime.fromisoformat(date_str.replace("Z", "+00:00"))

source/test_collect_plugins.py

@@ -6,6 +6,7 @@
     _convert_markdown_to_rst,
     _plugin_min_snakemake,
     _commit_url,
+    _cleanup_repository_url,
 )
 
 
@@ -253,3 +254,66 @@ def test_commit_url_unknown_type_non_none():
     """Test unknown repository type string returns base URL."""
     url = _commit_url("https://bitbucket.org/user/repo", "bitbucket", "abc1234")
     assert url == "https://bitbucket.org/user/repo"
+
+
+# Repository URL cleanup tests
+
+
+def test_cleanup_repository_url_github_https():
+    """Test cleaning up GitHub HTTPS URL."""
+    cleaned = _cleanup_repository_url("https://github.com/user/repo")
+    assert cleaned == "user/repo"
+
+
+def test_cleanup_repository_url_github_with_git_suffix():
+    """Test cleaning up GitHub URL with .git suffix."""
+    cleaned = _cleanup_repository_url("https://github.com/user/repo.git")
+    assert cleaned == "user/repo"
+
+
+def test_cleanup_repository_url_github_with_trailing_slash():
+    """Test cleaning up GitHub URL with trailing slash."""
+    cleaned = _cleanup_repository_url("https://github.com/user/repo/")
+    assert cleaned == "user/repo"
+
+
+def test_cleanup_repository_url_github_full():
+    """Test cleaning up GitHub URL with .git and trailing slash."""
+    cleaned = _cleanup_repository_url("https://github.com/user/repo.git/")
+    assert cleaned == "user/repo"
+
+
+def test_cleanup_repository_url_gitlab_https():
+    """Test cleaning up GitLab HTTPS URL."""
+    cleaned = _cleanup_repository_url("https://gitlab.com/user/repo")
+    assert cleaned == "user/repo"
+
+
+def test_cleanup_repository_url_gitlab_with_git_suffix():
+    """Test cleaning up GitLab URL with .git suffix."""
+    cleaned = _cleanup_repository_url("https://gitlab.com/user/repo.git")
+    assert cleaned == "user/repo"
+
+
+def test_cleanup_repository_url_http_protocol():
+    """Test cleaning up URL with HTTP protocol."""
+    cleaned = _cleanup_repository_url("http://github.com/user/repo")
+    assert cleaned == "user/repo"
+
+
+def test_cleanup_repository_url_empty_string():
+    """Test cleaning up empty string."""
+    cleaned = _cleanup_repository_url("")
+    assert cleaned == ""
+
+
+def test_cleanup_repository_url_none():
+    """Test cleaning up None value."""
+    cleaned = _cleanup_repository_url(None)
+    assert cleaned == ""
+
+
+def test_cleanup_repository_url_other_domain():
+    """Test cleaning up URL from other domain remains unchanged."""
+    cleaned = _cleanup_repository_url("https://bitbucket.org/user/repo")
+    assert cleaned == "https://bitbucket.org/user/repo"