fix: separate generate and cleanup actions#78
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughFour GitHub Actions workflow files are updated: deploy, generate, and test workflows are narrowed to trigger on Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Scheduler as "GitHub Scheduler\n(acts on cron)"
participant Runner as "Actions Runner\n(ubuntu-latest)"
participant Repo as "Repository\n(working tree)"
participant Pixi as "Pixi Tool\n(prefix-dev/setup-pixi)"
participant Pusher as "Push Action\n(ad-m/github-push-action@v1)"
rect rgba(0,128,0,0.5)
Scheduler->>Runner: trigger workflow (cron)
end
Runner->>Repo: checkout code
Runner->>Pixi: setup Pixi (with cache)
Runner->>Repo: git pull --rebase origin ${{ github.ref }}
loop for each OFFSET (0,10,...,90) sequentially
Runner->>Pixi: run `pixi run cleanup-catalog` (env: GITHUB_TOKEN, OFFSET)
Pixi-->>Repo: modify files (optional)
Runner->>Repo: git commit -m "Add changes" -a (ignore no-changes)
Runner->>Pusher: push branch using GITHUB_TOKEN
Pusher-->>Repo: update remote branch
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
.github/workflows/cleanup.yml (1)
8-9: Declare explicit repo write permission for this job.This job pushes commits; adding
permissions: contents: writeavoids failures when defaultGITHUB_TOKENpermissions are restricted.Suggested change
jobs: cleanup-catalog: + permissions: + contents: write runs-on: ubuntu-latest🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/cleanup.yml around lines 8 - 9, The cleanup-catalog job currently lacks explicit repository write permissions; add a permissions block under the cleanup-catalog job declaration to grant the workflow write access (e.g., set permissions: contents: write) so the job can push commits when using GITHUB_TOKEN; update the job named cleanup-catalog to include this permissions specification.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/cleanup.yml:
- Around line 37-41: The workflow currently uses the floating ref
ad-m/github-push-action@master in the "Push changes" step; replace that ref with
a specific immutable release tag (for example ad-m/github-push-action@v1 or a
concrete semver like `@v1.2.0`) to pin the action version and remove supply-chain
risk, updating the uses field for the step that has name "Push changes" to the
chosen fixed tag.
In @.github/workflows/generate.yml:
- Line 7: The generate.yml workflow currently triggers on pushes to main and
gets retriggered by the cleanup workflow's bot commits; update the
workflow-level trigger guard to skip runs when the event is a push from the
GitHub Actions bot while still allowing schedule and manual triggers
(workflow_dispatch and schedule). Concretely, add an if-condition that checks
github.event_name and github.actor (e.g., only proceed if github.event_name !=
'push' || github.actor != 'github-actions[bot]') so push events authored by
github-actions[bot] do not start the Generate run, but scheduled and manual
triggers remain unaffected.
---
Nitpick comments:
In @.github/workflows/cleanup.yml:
- Around line 8-9: The cleanup-catalog job currently lacks explicit repository
write permissions; add a permissions block under the cleanup-catalog job
declaration to grant the workflow write access (e.g., set permissions: contents:
write) so the job can push commits when using GITHUB_TOKEN; update the job named
cleanup-catalog to include this permissions specification.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a36a14fc-24ae-4a30-9751-f2e15f0f8bdf
📒 Files selected for processing (4)
.github/workflows/cleanup.yml.github/workflows/deploy.yml.github/workflows/generate.yml.github/workflows/test.yml
NavandarM
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #77
Summary by CodeRabbit