deps: Add official storage plugins#88
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesStorage plugin dependency updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Drafted, as during testing I realized adding the SFTP plugin appears to break snakemake 😬 |
859411b to
90e87b3
Compare
|
Removed the SFPT plugin now. I have already merged it on our fork, see the building action here. I'll undraft once that completed successfully. |
|
OK, thanks for testing @jonasfreimuth .
|
|
I just saw that in your build the linting is still failing because of a storage provider error: |
No, but that's expected I think because it doesn't rebuild the oblx page due to no changes having happened there that would warrant a rebuild. I have manually generated the rulegraph before using the Pixi env from this PR. I'll try and fudge with the data.json to force a rebuild on our fork's main branch.
Sure tbh I'm fine with whatever, so long as it includes the http storage plugin. |
To trigger a rerun for snakemake#88.
|
I've reset the update time of oblx in the data.json to |
To trigger a rerun for snakemake#88.
To trigger a rerun for snakemake#88.
|
Ok, very sorry but apparently that was not enough. I'll draft this again and let you know once things work properly on our fork. |
90e87b3 to
0f63419
Compare
|
Ok, I also removed the Error log``` INFO:root:Checking repos 0-1 (total: 1), of which 1 have a Snakefile. INFO:root:0 of 1 repos done. INFO:root:Processing TRON-Bioinformatics/oblx. ERROR:root:Traceback (most recent call last): File "/project/.pixi/envs/default/bin/snakemake", line 6, in from snakemake.cli import main File "/project/.pixi/envs/default/lib/python3.13/site-packages/snakemake/__init__.py", line 15, in from snakemake.shell import shell File "/project/.pixi/envs/default/lib/python3.13/site-packages/snakemake/shell.py", line 17, in from snakemake.utils import format, argvquote, cmd_exe_quote File "/project/.pixi/envs/default/lib/python3.13/site-packages/snakemake/utils.py", line 19, in from snakemake.common.configfile import _load_configfile File "/project/.pixi/envs/default/lib/python3.13/site-packages/snakemake/common/__init__.py", line 25, in from snakemake.exceptions import NestedCoroutineError File "/project/.pixi/envs/default/lib/python3.13/site-packages/snakemake/exceptions.py", line 10, in from snakemake_interface_common.exceptions import WorkflowError, ApiError ModuleNotFoundError: No module named 'snakemake_interface_common' ```As for further reducing the list of plugins, I wouldn't know by what metric. The plugin catalog doesn't give usage rankings I don't think. We could check the github stars, but to me that isn't really a metric that translates well enough to the useage numbers we would be interested in. |
|
Based on that, the latest build seems to work: https://tron-bioinformatics.github.io/snakemake-workflow-catalog/docs/workflows/TRON-Bioinformatics/oblx.html |
That's a valid point, and I thought about this as well. I'm not using storage plugins, can you quickly point out to me how those are used? With a profile, like one would use executor plugins (we do use the snakemake slurm plugin for example)? |
You generally wrap a URI in a That's also why we need to include the storage plugins in the env. Executor plugins for example are not integrated that close into a workflow, they just help with executing it, but a workflow can generally run without a plugin. When a workflow depends on external resources though, the stroage plugin is required to retrieve those resources in all cases. THat is at least my understanding. |
m-jahn
left a comment
There was a problem hiding this comment.
Thanks for testing. The performance of the generate-catalog action is also about the same as before, which is good.
|
Great! Thanks for reviewing and helping this get done! |
Proposed solution to #87.
Summary by CodeRabbit
Chores / Maintenance
Documentation