Ruby 3.4 / Delints / Spec Tidying#411
Closed
cycomachead wants to merge 8 commits into
Closed
Conversation
Replaces the Discourse forum SSO provider with Snap!Cloud's SSO endpoint. Since Snap!Cloud implements the same Discourse SSO protocol, this change updates the configuration URLs and environment variables while maintaining backward compatibility for the SSO secret. - Update SSO URL to point to snap.berkeley.edu API - Introduce OSEM_SNAP_SSO_SECRET and OSEM_SNAP_SSO_URL env vars - Fix provider detection logic to only require a secret for Discourse - Remove outdated "log in twice" UI warning - Add Discourse mock authentication for development and testing Co-authored-by: Claude Code <noreply@anthropic.com>
Revert custom provider detection logic in favor of using a placeholder OSEM_DISCOURSE_KEY. This aligns Snap!Cloud SSO with the existing OSEM provider pattern while documenting that only the secret is required for the actual handshake. Co-authored-by: Claude Code <noreply@anthropic.com>
cycomachead
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work In Progress