Skip to content

Commit 2512ded

Browse files
pftgclaude
andcommitted
refactor: inline build_null_difference in DifferenceFinder
One-line wrapper around Difference.build_null with only 2 call sites. Inlined directly, removing unnecessary indirection. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 7c3dcf7 commit 2512ded

1 file changed

Lines changed: 2 additions & 6 deletions

File tree

lib/capybara/screenshot/diff/difference_finder.rb

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -64,13 +64,13 @@ def call(comparison, quick_mode: true)
6464

6565
# Handle dimension differences
6666
unless driver.same_dimension?(comparison)
67-
result = build_null_difference(comparison, comparison.base_image_path, comparison.new_image_path, {different_dimensions: true})
67+
result = Difference.build_null(comparison, comparison.base_image_path, comparison.new_image_path, {different_dimensions: true})
6868
return quick_mode ? [false, result] : result
6969
end
7070

7171
# Handle identical pixels
7272
if driver.same_pixels?(comparison)
73-
result = build_null_difference(comparison, comparison.base_image_path, comparison.new_image_path)
73+
result = Difference.build_null(comparison, comparison.base_image_path, comparison.new_image_path)
7474
return quick_mode ? [true, result] : result
7575
end
7676

@@ -92,10 +92,6 @@ def without_tolerable_options?
9292
@without_tolerable_options
9393
end
9494

95-
# Build a no-difference result that represents identical images
96-
def build_null_difference(comparison, base_path, new_path, failed_by = nil)
97-
Difference.build_null(comparison, base_path, new_path, failed_by)
98-
end
9995
end
10096
end
10197
end

0 commit comments

Comments
 (0)