chore-usage-lightpanda-4dj

Author: pftg

Dockerfile

@@ -6,8 +6,7 @@
 FROM jetthoughts/cimg-ruby:4.0-chrome
 
 ENV DEBIAN_FRONTEND=noninteractive \
-    BUNDLE_PATH=/bundle \
-    LIGHTPANDA_DISABLE_TELEMETRY=true
+    BUNDLE_PATH=/bundle
 
 # Install system dependencies with cached apt
 RUN --mount=type=cache,target=/var/cache/apt,sharing=locked \
@@ -42,11 +41,6 @@ RUN --mount=type=cache,target=/var/cache/apt,sharing=locked \
       swig && \
     sudo rm -rf /var/lib/apt/lists/*
 
-# Install Lightpanda browser (experimental CDP-compatible headless browser)
-RUN sudo curl -L -o /usr/local/bin/lightpanda \
-      https://github.com/lightpanda-io/browser/releases/download/nightly/lightpanda-x86_64-linux && \
-    sudo chmod a+x /usr/local/bin/lightpanda
-
 # Setup directories and fix font config if file exists
 RUN sudo mkdir -p /bundle /tmp/.X11-unix && \
     sudo chmod 1777 /bundle /tmp/.X11-unix && \

README.md

@@ -688,16 +688,6 @@ RECORD_SCREENSHOTS=1 bin/dtest
 
 This skips screenshot comparisons and saves new baselines instead. Without this step, tests will fail because your local browser renders pixels differently from the previously committed baselines.
 
-#### Experimental: Lightpanda browser
-
-[Lightpanda](https://github.com/lightpanda-io/browser) is included as an experimental CDP-based headless browser. It can be enabled for the `cuprite` driver:
-
-```bash
-ENABLE_LIGHTPANDA=1 bin/dtest
-```
-
-**Note:** Lightpanda's CDP support does not yet cover viewport resizing or full execution context management, so screenshot comparison tests may fail. This is gated behind the env var until Lightpanda matures.
-
 ## Contributing
 
 See [CONTRIBUTING.md](CONTRIBUTING.md)

bin/dtest

@@ -7,7 +7,7 @@ export DOCKER_DEFAULT_PLATFORM=linux/amd64
 # Define allowed environment variables to pass to Docker
 ALLOWED_ENV_VARS=(
   "CI" "DEBUG" "TEST_ENV" "RAILS_ENV" "RACK_ENV" "COVERAGE" "DISABLE_ROLLBACK_COMPARISON_RUNTIME_FILES"
-  "RECORD_SCREENSHOTS" "TEST" "TESTOPTS" "SCREENSHOT_DRIVER" "ENABLE_LIGHTPANDA"
+  "RECORD_SCREENSHOTS" "TEST" "TESTOPTS" "SCREENSHOT_DRIVER"
 )
 
 # Build the Docker env args string
@@ -29,15 +29,7 @@ echo "Running tests..."
 DRIVERS=("cuprite" "selenium_chrome_headless" "selenium_headless")
 for driver in "${DRIVERS[@]}"; do
   echo "Running tests with $driver driver..."
-  if [[ "$driver" == "cuprite" && -n "$ENABLE_LIGHTPANDA" ]]; then
-    docker run $DOCKER_ENV_ARGS \
-      -e CAPYBARA_DRIVER="$driver" \
-      -e LIGHTPANDA_URL="ws://127.0.0.1:9222" \
-      -v ${PWD}:/app -v csd-bundle-cache:/bundle --rm -t csd:test \
-      bash -c 'lightpanda serve --host 127.0.0.1 --port 9222 & sleep 1 && bin/rake test "$@"' _ "$@" || exit 1
-  else
-    docker run $DOCKER_ENV_ARGS -e CAPYBARA_DRIVER="$driver" \
-      -v ${PWD}:/app -v csd-bundle-cache:/bundle --rm -t csd:test \
-      bin/rake test "$@" || exit 1
-  fi
+  docker run $DOCKER_ENV_ARGS -e CAPYBARA_DRIVER="$driver" \
+    -v ${PWD}:/app -v csd-bundle-cache:/bundle --rm -t csd:test \
+    bin/rake test "$@" || exit 1
 done

test/support/setup_capybara_drivers.rb

@@ -69,15 +69,10 @@
     process_timeout: ENV["CI"] ? 40 : 5,
     screen_size: SCREEN_SIZE,
     timeout: ENV["CI"] ? 40 : 5,
-    window_size: SCREEN_SIZE
+    window_size: SCREEN_SIZE,
+    browser_options: CHROME_ARGS
   }
 
-  if ENV["LIGHTPANDA_URL"]
-    cuprite_options[:url] = ENV["LIGHTPANDA_URL"]
-  else
-    cuprite_options[:browser_options] = CHROME_ARGS
-  end
-
   Capybara.register_driver(:cuprite) do |app|
     Capybara::Cuprite::Driver.new(app, **cuprite_options)
   end